scrooge: Remove warnings from scrooge-generator-test

Problem:

We got some compiler warnings for scrooge-generator-test, most of them are
unused import.

Solution:

Fix it.

RB_ID=916144

Author: yufangong

scrooge-generator-tests/src/test/scala/BUILD

@@ -39,5 +39,6 @@ junit_tests(
     'scrooge/scrooge-generator-tests/src/test/thrift:thrift',
     'util/util-core/src/main/scala:scala',
   ],
+  fatal_warnings=True,
   sources=rglobs('*.scala'),
 )

scrooge-generator-tests/src/test/scala/com/twitter/scrooge/android_generator/AndroidGeneratorSpec.scala

@@ -9,12 +9,9 @@ import com.twitter.scrooge.mustache.ScalaObjectHandler
 import com.google.common.base.Charsets
 import com.google.common.io.CharStreams
 import com.twitter.scrooge.ast._
-import com.twitter.scrooge.{integration_android => androidGen}
 import com.twitter.scrooge.frontend.{ResolvedDocument, TypeResolver}
 import com.twitter.scrooge.testutil.Spec
 import com.twitter.scrooge.testutil.Utils.verify
-import org.apache.thrift.protocol.TBinaryProtocol
-import org.apache.thrift.transport.TMemoryBuffer
 import org.mockito.Mockito._
 import thrift.complete.android.test1.{StructXA, StructXB, SimpleWithDefaults}
 import thrift.complete.android.test2.ComplexCollections

scrooge-generator-tests/src/test/scala/com/twitter/scrooge/backend/NamespaceSpec.scala

@@ -4,7 +4,6 @@ import com.twitter.scrooge.testutil.Spec
 
 class NamespaceSpec extends Spec {
   "Scala Generator" should {
-    import foo._
     import bar._
     import com.fake._
     "import from another namespace" in {

scrooge-generator-tests/src/test/scala/com/twitter/scrooge/backend/ScalaGeneratorSpec.scala

@@ -2,7 +2,6 @@ package com.twitter.scrooge.backend
 
 import com.twitter.conversions.time._
 import com.twitter.finagle.{Service, SourcedException}
-import com.twitter.finagle.thrift.ThriftServiceIface
 import com.twitter.scrooge.testutil.{EvalHelper, JMockSpec}
 import com.twitter.scrooge.{ThriftStruct, ThriftException}
 import com.twitter.util.{Await, Future}
@@ -11,13 +10,10 @@ import java.nio.ByteBuffer
 import org.apache.thrift.protocol._
 import org.apache.thrift.transport.TMemoryBuffer
 import org.jmock.Expectations
-import org.jmock.Expectations.{any, returnValue}
+import org.jmock.Expectations.returnValue
 import thrift.test._
 import thrift.test1._
 import thrift.test2._
-import thrift.`def`.default._
-import includes.a.thriftscala._
-import includes.b.thriftscala._
 import inheritance.aaa.{Aaa, Box}
 import inheritance.bbb.Bbb
 import inheritance.ccc.Ccc
@@ -506,7 +502,7 @@ class ScalaGeneratorSpec extends JMockSpec with EvalHelper {
         "missing required value throws exception during deserialization" should {
           "with no default value" in { cycle => import cycle._
             val protocol = mock[TProtocol]
-            expecting { e => import e._
+            expecting { e =>
               emptyRead(e, protocol)
             }
 
@@ -519,7 +515,7 @@ class ScalaGeneratorSpec extends JMockSpec with EvalHelper {
 
           "with default value" in { cycle => import cycle._
             val protocol = mock[TProtocol]
-            expecting { e => import e._
+            expecting { e =>
               emptyRead(e, protocol)
             }
 
@@ -799,7 +795,7 @@ class ScalaGeneratorSpec extends JMockSpec with EvalHelper {
       "zero fields" should {
         "read" in { cycle => import cycle._
           val protocol = mock[TProtocol]
-          expecting { e => import e._
+          expecting { e =>
             emptyRead(e, protocol)
           }
 

scrooge-generator-tests/src/test/scala/com/twitter/scrooge/backend/ServiceGeneratorSpec.scala

@@ -6,7 +6,7 @@ import com.twitter.finagle.param.Stats
 import com.twitter.finagle.service.{ResponseClass, ResponseClassifier, ReqRep}
 import com.twitter.finagle.{Address, ListeningServer, Name, Thrift, Service, SimpleFilter, SourcedException}
 import com.twitter.finagle.stats.InMemoryStatsReceiver
-import com.twitter.finagle.thrift.{ThriftClientRequest, ThriftServiceIface}
+import com.twitter.finagle.thrift.ThriftClientRequest
 import com.twitter.scrooge.ThriftException
 import com.twitter.scrooge.testutil.{EvalHelper, JMockSpec}
 import com.twitter.util.{Await, Future, Return}

scrooge-generator-tests/src/test/scala/com/twitter/scrooge/mustache/HandlebarSpec.scala

@@ -38,7 +38,7 @@ class HandlebarSpec extends Spec {
     }
 
     "optional blocks" in {
-      val template = "You {{#money}}have ${{money}}{{/money}}{{^money}}are broke{{/money}}."
+      val template = s"You {{#money}}have $${{money}}{{/money}}{{^money}}are broke{{/money}}."
       Handlebar.generate(template, Dictionary("money" -> v("5"))) must be("You have $5.")
       Handlebar.generate(template, Dictionary()) must be("You are broke.")
       Handlebar.generate(template, Dictionary("money" -> v(true))) must be("You have $true.")