Unused imports included in headers break build

[chrisbenincasa]

Unused imports are included in the headers of generated files causing 2.12 builds with the default -Yfatal-warnings` setting to fail (unless the correct linting options are unset)

Expected behavior

Scrooge generates files with headers including only the imports the current file needs.

Actual behavior

Scrooge generates import statements for classes that are never used.

Steps to reproduce the behavior

Generate a simple class with the following Thrift

struct Simple {
  1: required string simple
}

Compiling with 2.12, with -Xfatal-warnings and -Xlint set, the build will fail.

[yufangong]

Hi @chrisbenincasa , thanks for the issue.
I think this is because scrooge template includes all imports there, the import is unused by some services is being used by others. (I can be totally wrong tho)

Do you want to do some investigation on this issue to find a solution? Get more service ad-hoc generated code instead maybe. Patches are more than welcome!

[chrisbenincasa]

@yufangong sorry for the delayed reply! I can take a look at what it would take to fix this up.

[yufangong]

@chrisbenincasa sounds great! Thank you!

[DieMyst]

+1

[henryxparker]

For others, a way to get around this problem is to add

Compile / scalacOptions += "-Wconf:cat=unused&src=src_managed/.*:s",
Compile / scalacOptions +="-Wconf:cat=deprecation&src=src_managed/.*:s"

to your build.sbt