Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect approach to checking pre and post fork #1

Open
Melvillian opened this issue Sep 13, 2022 · 1 comment
Open

Incorrect approach to checking pre and post fork #1

Melvillian opened this issue Sep 13, 2022 · 1 comment

Comments

@Melvillian
Copy link

In ETHwPNToken.sol you check for if the hardfork has occurred using block.difficulty == 0. However, according to this Ethereum article for application devs, the check should be block.difficulty > 2**64 == isPostFork:

https://blog.ethereum.org/en/2021/11/29/how-the-merge-impacts-app-layer
twtaylor added a commit that referenced this issue Sep 13, 2022
@twtaylor
Fixing issue #1 and compilation issue
fb6229e
@twtaylor
Copy link
Owner

Ok, this should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Melvillian @twtaylor