You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge bitcoin-core/gui-qml#487: Use handlers with explicit parameters in main.qml and DesktopWallets.qml
99d5da865466924257daf4d8b59db468992c69e6 Update signal handlers in DesktopWallets.qml to have explicit parameters (johnny9)
da6bc7cd97f4c5be66ab77411509fac5a145cde8 Update signal handlers in main.qml to have explicit parameters (johnny9)
Pull request description:
Signals with parameters should have handlers that explicitly define the arguments. Without this, Qt will throw a warning in the log stating that injection or parameters is deprecated.
fixes #481
ACKs for top commit:
hebasto:
ACK 99d5da865466924257daf4d8b59db468992c69e6, tested on Ubuntu 24.04.
Tree-SHA512: 510ab99aeaa8418cc28886452bed28d7cc8c6697286e89d19e4a5cc593dda5f3d07d1e7ca5856be60dc8c6efb50d8e1626ca1a111457dbede6267bf6d1bfe62c
0 commit comments