Is quick_orm thread-safe?

[kunzhipeng]

To avoid duplicate records, i used following method:

def save_phone(self, company, _phone):
        """save phone into phones table
        """
        _phone = self.format_phone(_phone)
        try:
            self.db.session.query(Phones).filter_by(company=company, phone=_phone).one()
        except orm_exc.NoResultFound:
            phone = Phones()
            phone.company = company
            phone.phone = _phone
            self.db.session.add_then_commit(phone)

But there are still duplicate data in the table.

[tylerlong]

Regarding thread-safe, it should be the same as SQLAlchemy.

In order to prevent duplicate records, you'd better add an unique index to the database.

Wait a minute and see if I can get an example for you.

[tylerlong]

Please refer to the following example:

from sqlalchemy.schema import UniqueConstraint

class Phones:
    company = Column(String(50))
    phone = Column(String(50))
    __table_args__ = [UniqueConstraint('company', 'phone')]

[kunzhipeng]

Thanks a lot.

Do you know why my following code is still not working as expected?

lock = threading.Lock()

def synchronous(f):
    def call(*args, **kwargs):
        lock.acquire()
        try:
            return f(*args, **kwargs)
        finally:
            lock.release()
    return call


@synchronous
def save_phone(self, company, _phone):
        """save phone into phones table
        """
        _phone = self.format_phone(_phone)
        try:
            self.db.session.query(Phones).filter_by(company=company, phone=_phone).one()
        except orm_exc.NoResultFound:
            phone = Phones()
            phone.company = company
            phone.phone = _phone
            self.db.session.add_then_commit(phone)

[tylerlong]

I cannot comment on your code because I have little experience on Python multi-threading.

[kunzhipeng]

I doubt the add_then_commit() operation doesn't insert the new row immediately. What do you think?

[tylerlong]

check the source code: https://github.com/tylerlong/quick_orm/blob/master/quick_orm/extensions.py