Simple aliases not working properly if getTable method is defined

[Tofandel]

Quick example:

class RelatedItem extends Model {
    public function related()
    {
        return $this->morphTo('related');
    }
   
   // This causes the issue (but I don't control it as it's part of a lib)
    public function getTable()
    {
        return config('twill.related_table', 'twill_related');
    }
}
class Video extends Model {
    public function relatableItems(): MorphMany
    {
        return $this->morphMany(RelatedItem::class, 'related');
    }
}

Video::query()->joinRelation('relatableItems as relatable')->toRawSQL()

Which produces the following invalid SQL

select * from `videos` inner join `twill_related` as `relatable` on `twill_related`.`related_id` = `videos`.`id` and `twill_related`.`related_type` = 'video' where `videos`.`deleted_at` is null

Unknown column 'twill_related.related_id' in ON

Because the table is aliased, the resulting SQL should have been

select * from `videos` inner join `twill_related` as `relatable` on `relatable`.`related_id` = `videos`.`id` and `relatable`.`related_type` = 'video' where `videos`.`deleted_at` is null

This also happens with hasMany or qualifyColumn

public function questions(): HasMany
{
        $q = $this->hasMany(Block::class, 'blockable_id');
        return $q
            ->where($q->qualifyColumn('type'), 'survey-input')
}

inner join `twill_blocks` as `que` on `twill_blocks`.`blockable_id` = `elearning_surveys`.`id` and `twill_blocks`.`type` = 'survey-input'

VS expected

inner join `twill_blocks` as `que` on `que`.`blockable_id` = `elearning_surveys`.`id` and `que`.`type` = 'survey-input'

[Tofandel]

This issue is directly because of the fact the lib is trying to override the table of the model for the alias to qualify it's wheres

laravel-relation-joins/src/RelationJoinQuery.php

Lines 145 to 164 in 286425b

	$table = $on = $relation->getTable();
	}
	$query->join($table, function ($join) use ($relation, $on) {
	$join->on($on.'.'.$relation->getForeignPivotKeyName(), '=', $relation->getQualifiedParentKeyName());
	}, null, null, $type);
	// When a belongs to many relation uses an eloquent model to define the pivot
	// in between the two models, we should elevate the join through eloquent
	// so that query scopes can be leveraged. This is opt-in functionality.
	if (($using = $relation->getPivotClass()) != Pivot::class) {
	$query->getQuery()->joins[0] = new EloquentJoinClause(
	$query->getQuery()->joins[0], // @phpstan-ignore offsetAccess.notFound (Join is added above)
	(new $using)->setTable($on)
	);
	}
	$query->whereColumn(
	$relation->getRelated()->qualifyColumn($relation->getRelatedKeyName()),

This is really not a good approach and an internal qualifyColumn should just be used or all the where should be parsed to replace already qualified columns with their aliases (likely the prefered approach to handle this case

public function questions(): HasMany
{
        $q = $this->hasMany(Block::class, 'blockable_id');
        return $q
            ->where($q->qualifyColumn('type'), 'survey-input')
}

[tylernathanreed]

@Tofandel,

It looks like the issue here is that the models in area17/twill don't respect the setTable function, which is a requirement for this package to function.

Implementing some sort of after-the-fact parser to replace table names is a highly complex solution, and one that I originally explored when first implementing aliases in this package. I ultimately went with modifying the table during runtime via setTable, as that offered the highest compatibility, was a first-party feature, and an easy-to-understand solution.

I've opened a PR for twill (#2737) to resolve the issue on their end. I've also added test coverage over here to ensure that the changes I recommended for them will work, and still allow other third-party packages to override the getTable method.

I'm going to mark this issue as resolved. Please follow up with the twill PR to see when you're able to start using aliases again.