Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glint accidentally resolves local file over package name containing ".js" #724

Open
ef4 opened this issue Jun 12, 2024 · 0 comments
Open

Comments

@ef4
Copy link
Contributor

ef4 commented Jun 12, 2024

If you have an import like import * from "chess.js", tsc correctly treats this as a package dependency. But using glint, if you also have a local file named "chess.gts", glint resolves the import to the local file.

It should probably be checking that the import specifier really starts with . before attempting to do its extra extension resolving.

ef4 added a commit to cardstack/boxel that referenced this issue Jun 12, 2024
- needed to rename chess.gts to chess-game.gts because of typed-ember/glint#724
ef4 added a commit to cardstack/boxel that referenced this issue Jun 12, 2024
- needed to rename chess.gts to chess-game.gts because of typed-ember/glint#724
jurgenwerk pushed a commit to cardstack/boxel that referenced this issue Jun 19, 2024
- needed to rename chess.gts to chess-game.gts because of typed-ember/glint#724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant