Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current versions do not work with GSI #5

Open
valpackett opened this issue Jul 18, 2019 · 1 comment
Open

Current versions do not work with GSI #5

valpackett opened this issue Jul 18, 2019 · 1 comment

Comments

@valpackett
Copy link

hex_jasmine-437-0424-fe6fea984600 works fine, but if I upgrade to hex_jasmine-791-0620-f129abd5243dd or hex_jasmine-699-0605-c9f1176e4abbb, it doesn't boot (reboots after the Android One screen instead of showing the Lineage splash screen)

  • Andy Yan's Lineage GSI build lineage-16.0-20190707-UNOFFICIAL-treble_arm64_avN.img.xz
  • vendor.img from jasmine_global_images_V10.0.10.0.PDIMIXM_20190611.0000.00_9.0_9e6473956a.tgz
PradyX pushed a commit to PradyX/hex_kernel_xiaomi_jasmine that referenced this issue Sep 18, 2019
commit cf3591ef832915892f2499b7e54b51d4c578b28c upstream.

Revert the commit bd293d071ffe65e645b4d8104f9d8fe15ea13862. The proper
fix has been made available with commit d0a255e795ab ("loop: set
PF_MEMALLOC_NOIO for the worker thread").

Note that the fix offered by commit bd293d071ffe doesn't really prevent
the deadlock from occuring - if we look at the stacktrace reported by
Junxiao Bi, we see that it hangs in bit_wait_io and not on the mutex -
i.e. it has already successfully taken the mutex. Changing the mutex
from mutex_lock to mutex_trylock won't help with deadlocks that happen
afterwards.

PID: 474    TASK: ffff8813e11f4600  CPU: 10  COMMAND: "kswapd0"
   #0 [ffff8813dedfb938] __schedule at ffffffff8173f405
   tytydraco#1 [ffff8813dedfb990] schedule at ffffffff8173fa27
   tytydraco#2 [ffff8813dedfb9b0] schedule_timeout at ffffffff81742fec
   tytydraco#3 [ffff8813dedfba60] io_schedule_timeout at ffffffff8173f186
   tytydraco#4 [ffff8813dedfbaa0] bit_wait_io at ffffffff8174034f
   tytydraco#5 [ffff8813dedfbac0] __wait_on_bit at ffffffff8173fec8
   tytydraco#6 [ffff8813dedfbb10] out_of_line_wait_on_bit at ffffffff8173ff81
   tytydraco#7 [ffff8813dedfbb90] __make_buffer_clean at ffffffffa038736f [dm_bufio]
   #8 [ffff8813dedfbbb0] __try_evict_buffer at ffffffffa0387bb8 [dm_bufio]
   #9 [ffff8813dedfbbd0] dm_bufio_shrink_scan at ffffffffa0387cc3 [dm_bufio]
  #10 [ffff8813dedfbc40] shrink_slab at ffffffff811a87ce
  #11 [ffff8813dedfbd30] shrink_zone at ffffffff811ad778
  #12 [ffff8813dedfbdc0] kswapd at ffffffff811ae92f
  #13 [ffff8813dedfbec0] kthread at ffffffff810a8428
  #14 [ffff8813dedfbf50] ret_from_fork at ffffffff81745242

Signed-off-by: Mikulas Patocka <[email protected]>
Cc: [email protected]
Fixes: bd293d071ffe ("dm bufio: fix deadlock with loop device")
Depends-on: d0a255e795ab ("loop: set PF_MEMALLOC_NOIO for the worker thread")
Signed-off-by: Mike Snitzer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
@Nitrovenom
Copy link

Close wen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants