Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

should we remove contactsPassingFilter from the public API? #40

Open
adam-zethraeus opened this issue Nov 11, 2016 · 2 comments
Open

should we remove contactsPassingFilter from the public API? #40

adam-zethraeus opened this issue Nov 11, 2016 · 2 comments
Labels
question

Comments

@adam-zethraeus
Copy link
Contributor

No description provided.

@maxwellE
Copy link
Contributor

maxwellE commented Mar 2, 2017

Im not sure if there is much gain to removing it, it is also a breaking change

@adam-zethraeus
Copy link
Contributor Author

adam-zethraeus commented Mar 7, 2017 •
edited
Loading

i think there's value in improving the api, but we should collect this with other changes that require a major bump.

It's a shame we didn't do this for v2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-zethraeus @maxwellE