Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

devexp: Default to thrift if and only if the endpoint contains "::" #56

Open
Raynos opened this issue Sep 24, 2015 · 2 comments
Open

devexp: Default to thrift if and only if the endpoint contains "::" #56

Raynos opened this issue Sep 24, 2015 · 2 comments

Comments

@Raynos
Copy link
Contributor

Raynos commented Sep 24, 2015

All thrift endpoints contain "::"

If none of the the --thrift, --json or --raw flags are set we should default to thrift if "::" and default to json otherwise.

We can re-consider thrift vs json as the global default in a separate issue.

cc @malandrew @kriskowal @ShanniLi @eculver

@kriskowal
Copy link
Contributor

Good idea, especially if that implies that tcurl should hit the Meta::thrift* endpoint first to obtain the IDL unless it was already supplied from one on hand. We could simply infer whether as=json or as=thrift from this heuristic and not have that separate discussion about a global default.

@kriskowal
Copy link
Contributor

This has landed in #60 but is moot until we get #61 (obtain IDL from Meta::thriftIDL) which is blocking on a proper implementation of Meta::thriftIDL with multiple sources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants