indecipherable thrift error

[blampe]

Reported by @Torwegia:

(env)uber@tor:~$ tcurl --timeout 10000 -p 127.0.0.1:21300 -t thrift/service.thrift  foo FOO::auth -3 '{"paymentProfileId": "a", "jobId": "b", "amount": 3}'
TCURL ERROR: Got unexpected unserializable thrift for arg3 ~ { endpoint: 'BANKEMOJI::auth',
  direction: 'out.request',
  ok: undefined,
  bodyErr:
   { [TchannelThriftHandlerStringifyErrorBodyFailedError: Could not stringify body (res2) argument.
   Expected Thrift serializable res2 for endpoint FOO::auth.]
     type: 'tchannel-thrift-handler.stringify-error.body-failed',
     message: 'Could not stringify body (res2) argument.\nExpected Thrift serializable res2 for endpoint BANKEMOJI::auth.',
     isSerializationError: true,
     endpoint: 'BANKEMOJI::auth',
     ok: undefined,
     body: { paymentProfileId: 'a', jobId: 'b', amount: 3 },
     direction: 'out.request',
     name: 'TchannelThriftHandlerStringifyErrorBodyFailedError',
     causeMessage: 'invalid argument, expected a buffer',
     origMessage: 'invalid argument, expected a buffer',
     fullType: 'tchannel-thrift-handler.stringify-error.body-failed~!~bufrw.invalid-argument' } }
Error response received for the as-thrift request.
[Error: Got unexpected unserializable thrift for arg3]

Thrift file looks like this:

string auth(
    1: required UUID paymentProfileId,
    2: required UUID jobId,
    3: required i64 amount,

[kriskowal]

• First step is to unravel transitive error.cause and log the entire chain. The wrapped error from TChannel is not at its face useful to the end user. The next in the chain "invalid argument, expected buffer" is more useful and I believe has properties that show exactly where the error occurred.
• Secondly, we need to upgrade TChannel in TCurl for the new ThriftRW which can coerce numbers to buffers.
• Thirdly, we need to make a special case for this class of error and display what the user needs.

[ShanniLi]

This commit should fix the error:
3cd2575

I have assign the issue to myself as a task to improve the tcurl error messages.

[111eric]

We actually just ran into the same issue, and after some digging we think the issue is with i64 type. If we change it to i32 it works fine, but otherwise we get the stringify issue above.

Any insights as of why this happens? Thanks!

[kriskowal]

Rolling a fix up now. We will deploy a new TCurl tomorrow or wednesday.

[danqing]

Awesome thanks @kriskowal !

Can we somehow patch the updated version before it's deployed?

[danqing]

And just realized that it's the same as #54.

[kriskowal]

Fixed on master and npm i [email protected]

[111eric]

@kriskowal
Thanks for the quick turn on this.

When will 4.16.0 be available?

[kriskowal]

@111eric it is available to install from npm now. We will roll it into production this week. This version also has a man page by @ShanniLi