Skip to content

Commit 799899d

Browse files
committed
Improve linting
1 parent caf8241 commit 799899d

File tree

4 files changed

+28
-12
lines changed

4 files changed

+28
-12
lines changed

.eslintrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
{
2+
"extends": "eslint:recommended",
23
"parserOptions": {
34
"ecmaVersion": 2017,
45
"ecmaFeatures": {
56
"experimentalObjectRestSpread": true
67
}
78
},
9+
"env": {
10+
"node": true,
11+
"es6": true
12+
},
813
"plugins": [
914
"prettier"
1015
],

__tests__/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* LICENSE file in the root directory of this source tree.
55
*/
66

7+
/* eslint-env jest */
8+
79
const t = require('assert');
810

911
test('dummy test', () => {

index.js

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,26 @@ module.exports = robot => {
1313
async function check(context) {
1414
const {github} = context;
1515
const pr = context.payload.pull_request;
16-
const issues = pr.body.match(issueRegex());
17-
const status =
18-
issues === null
19-
? {
20-
state: 'failure',
21-
description: 'PR does not reference an issue',
22-
}
23-
: {
24-
state: 'success',
25-
description: 'PR references an issue',
26-
};
16+
17+
function hasIssue() {
18+
const issues = pr.body.match(issueRegex());
19+
if (issues !== null) {
20+
return true;
21+
}
22+
const repo = context.payload.repository.full_name;
23+
const urlRegex = new RegExp(`${repo}/issues/\\d+`, 'g');
24+
return pr.body.match(urlRegex) !== null;
25+
}
26+
27+
const status = hasIssue()
28+
? {
29+
state: 'success',
30+
description: 'PR references an issue',
31+
}
32+
: {
33+
state: 'failure',
34+
description: 'PR does not reference an issue',
35+
};
2736

2837
setStatus(status);
2938

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"dependencies": {
1515
"issue-regex": "^1.0.0",
16-
"probot": "^0.11.0"
16+
"probot": "^3.0.0"
1717
},
1818
"devDependencies": {
1919
"eslint": "^4.8.0",

0 commit comments

Comments
 (0)