a bit more

Author: louis-z

NGitLab.Mock/Clients/PipelineClient.cs

@@ -156,12 +156,6 @@ public Models.Job[] GetJobs(long pipelineId)
         }
     }
 
-    [Obsolete("Use JobClient.GetJobs() instead")]
-    public IEnumerable<Models.Job> GetJobsInProject(JobScope scope)
-    {
-        throw new NotImplementedException();
-    }
-
     public IEnumerable<PipelineBasic> Search(PipelineQuery query)
     {
         using (Context.BeginOperationScope())

NGitLab/IPipelineClient.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
 using NGitLab.Models;
@@ -29,13 +28,6 @@ public interface IPipelineClient
 
     GitLabCollectionResponse<Job> GetAllJobsAsync();
 
-    /// <summary>
-    /// Get jobs in a project meeting the scope
-    /// </summary>
-    /// <param name="scope"></param>
-    [Obsolete("Use JobClient.GetJobs() instead")]
-    IEnumerable<Job> GetJobsInProject(JobScope scope);
-
     /// <summary>
     /// Returns the jobs of a pipeline.
     /// </summary>

NGitLab/Impl/PipelineClient.cs

@@ -31,19 +31,6 @@ public GitLabCollectionResponse<Job> GetAllJobsAsync()
         return _api.Get().GetAllAsync<Job>($"{_projectPath}/jobs");
     }
 
-    [Obsolete("Use JobClient.GetJobs() instead")]
-    public IEnumerable<Job> GetJobsInProject(JobScope scope)
-    {
-        var url = $"{_projectPath}/jobs";
-
-        if (scope != JobScope.All)
-        {
-            url = Utils.AddParameter(url, "scope", scope.ToString().ToLowerInvariant());
-        }
-
-        return _api.Get().GetAll<Job>(url);
-    }
-
     public Pipeline this[long id] => _api.Get().To<Pipeline>($"{_pipelinesPath}/{id.ToStringInvariant()}");
 
     public Task<Pipeline> GetByIdAsync(long id, CancellationToken cancellationToken = default)

NGitLab/Models/CompareQuery.cs

@@ -1,6 +1,4 @@
-using System.Text.Json.Serialization;
-
-namespace NGitLab.Models;
+namespace NGitLab.Models;
 
 /// <summary>
 /// Query details for comparison of branches/tags/commit hashes

NGitLab/Models/JobScope.cs

@@ -2,20 +2,6 @@
 
 namespace NGitLab.Models;
 
-[Obsolete("Use JobScopeMask instead")]
-public enum JobScope
-{
-    All,
-    Created,
-    Pending,
-    Running,
-    Failed,
-    Success,
-    Canceled,
-    Skipped,
-    Manual,
-}
-
 [Flags]
 public enum JobScopeMask
 {

NGitLab/PublicAPI.Unshipped.txt

@@ -804,7 +804,6 @@ NGitLab.Impl.PipelineClient.GetByIdAsync(long id, System.Threading.CancellationT
 NGitLab.Impl.PipelineClient.GetJobs(long pipelineId) -> NGitLab.Models.Job[]
 NGitLab.Impl.PipelineClient.GetJobs(NGitLab.Models.PipelineJobQuery query) -> System.Collections.Generic.IEnumerable<NGitLab.Models.Job>
 NGitLab.Impl.PipelineClient.GetJobsAsync(NGitLab.Models.PipelineJobQuery query) -> NGitLab.GitLabCollectionResponse<NGitLab.Models.Job>
-NGitLab.Impl.PipelineClient.GetJobsInProject(NGitLab.Models.JobScope scope) -> System.Collections.Generic.IEnumerable<NGitLab.Models.Job>
 NGitLab.Impl.PipelineClient.GetTestReports(long pipelineId) -> NGitLab.Models.TestReport
 NGitLab.Impl.PipelineClient.GetTestReportsSummary(long pipelineId) -> NGitLab.Models.TestReportSummary
 NGitLab.Impl.PipelineClient.GetVariables(long pipelineId) -> System.Collections.Generic.IEnumerable<NGitLab.Models.PipelineVariable>
@@ -1002,7 +1001,6 @@ NGitLab.IPipelineClient.GetByIdAsync(long id, System.Threading.CancellationToken
 NGitLab.IPipelineClient.GetJobs(long pipelineId) -> NGitLab.Models.Job[]
 NGitLab.IPipelineClient.GetJobs(NGitLab.Models.PipelineJobQuery query) -> System.Collections.Generic.IEnumerable<NGitLab.Models.Job>
 NGitLab.IPipelineClient.GetJobsAsync(NGitLab.Models.PipelineJobQuery query) -> NGitLab.GitLabCollectionResponse<NGitLab.Models.Job>
-NGitLab.IPipelineClient.GetJobsInProject(NGitLab.Models.JobScope scope) -> System.Collections.Generic.IEnumerable<NGitLab.Models.Job>
 NGitLab.IPipelineClient.GetTestReports(long pipelineId) -> NGitLab.Models.TestReport
 NGitLab.IPipelineClient.GetTestReportsSummary(long pipelineId) -> NGitLab.Models.TestReportSummary
 NGitLab.IPipelineClient.GetVariables(long pipelineId) -> System.Collections.Generic.IEnumerable<NGitLab.Models.PipelineVariable>
@@ -2572,16 +2570,6 @@ NGitLab.Models.JobQuery.PerPage.get -> int?
 NGitLab.Models.JobQuery.PerPage.set -> void
 NGitLab.Models.JobQuery.Scope.get -> NGitLab.Models.JobScopeMask
 NGitLab.Models.JobQuery.Scope.set -> void
-NGitLab.Models.JobScope
-NGitLab.Models.JobScope.All = 0 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Canceled = 6 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Created = 1 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Failed = 4 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Manual = 8 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Pending = 2 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Running = 3 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Skipped = 7 -> NGitLab.Models.JobScope
-NGitLab.Models.JobScope.Success = 5 -> NGitLab.Models.JobScope
 NGitLab.Models.JobScopeMask
 NGitLab.Models.JobScopeMask.All = NGitLab.Models.JobScopeMask.Created | NGitLab.Models.JobScopeMask.Pending | NGitLab.Models.JobScopeMask.Running | NGitLab.Models.JobScopeMask.Failed | NGitLab.Models.JobScopeMask.Success | NGitLab.Models.JobScopeMask.Canceled | NGitLab.Models.JobScopeMask.Skipped | NGitLab.Models.JobScopeMask.Manual -> NGitLab.Models.JobScopeMask
 NGitLab.Models.JobScopeMask.Canceled = 32 -> NGitLab.Models.JobScopeMask