pam/cli: Factorize list views code and remove empty vertical spaces (#840)

We have two stages using lists at the moment that are basically
repeating the same code in most logic, avoid such duplication and handle
everything in a new list type that is used as base of both the broker
and authentication selection stages.

Then, Bubbletea by default shows lists in full screen mode, however this
is far from optimal in our implementation because the command triggering
the pam request is hidden making the user to lose the context in a
security-related operation.

UDENG-6445

Author: 3v1n0

Diff for: pam/integration-tests/testdata/golden/TestCLIAuthenticate/Authenticate_user_switching_to_local_broker

@@ -35,26 +35,6 @@ Gimme your password:
   Select your provider
 
 > 1. local
-  2. ExampleBroker
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 PAM Info Message: auth=incomplete
 PAM Authenticate()
   User: "user-integration-switch-broker"

Diff for: pam/integration-tests/testdata/golden/TestCLIAuthenticate/Deny_authentication_if_user_does_not_exist

@@ -14,26 +14,6 @@ Username: user-unexistent
   Select your provider
 
   1. local
-> 2. ExampleBroker
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 PAM Error Message: can't select broker: user "user-unexistent" does not exist
 PAM Authenticate()
   User: "user-unexistent"

Diff for: pam/integration-tests/testdata/golden/TestCLIAuthenticate/Exit_authd_if_local_broker_is_selected

@@ -14,26 +14,6 @@ Username: user-local-broker
   Select your provider
 
 > 1. local
-  2. ExampleBroker
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 PAM Info Message: auth=incomplete
 PAM Authenticate()
   User: "user-local-broker"

Diff for: pam/integration-tests/testdata/golden/TestCLIChangeAuthTok/Exit_authd_if_local_broker_is_selected

@@ -14,26 +14,6 @@ Username: user-integration-cli-passwd-exit-authd-if-local-broker-is-selected
   Select your provider
 
 > 1. local
-  2. ExampleBroker
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 PAM Info Message: chauthtok=incomplete
 PAM ChangeAuthTok()
   User: "user-integration-cli-passwd-exit-authd-if-local-broker-is-selected"

Diff for: pam/integration-tests/testdata/golden/TestCLIChangeAuthTok/Prevent_change_password_if_user_does_not_exist

@@ -14,26 +14,6 @@ Username: user-unexistent
   Select your provider
 
   1. local
-> 2. ExampleBroker
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 PAM Error Message: can't select broker: user "user-unexistent" does not exist
 PAM ChangeAuthTok()
   User: "user-unexistent"

Diff for: pam/internal/adapter/authentication.go

@@ -194,6 +194,7 @@ func (m *authenticationModel) Update(msg tea.Msg) (authModel authenticationModel
 		return *m, tea.Sequence(m.cancelIsAuthenticated(), sendEvent(AuthModeSelected{}))
 
 	case newPasswordCheck:
+		log.Debugf(context.TODO(), "%T", msg)
 		currentSecret := m.currentSecret
 		return *m, func() tea.Msg {
 			res := newPasswordCheckResult{ctx: msg.ctx, password: msg.password}
@@ -204,6 +205,7 @@ func (m *authenticationModel) Update(msg tea.Msg) (authModel authenticationModel
 		}
 
 	case newPasswordCheckResult:
+		log.Debugf(msg.ctx, "%T: %s", msg, msg.msg)
 		if m.clientType != Gdm {
 			// This may be handled by the current model, so don't return early.
 			break

Diff for: pam/internal/adapter/authmodeselection.go

@@ -3,11 +3,9 @@ package adapter
 import (
 	"context"
 	"fmt"
-	"strconv"
 
-	"github.com/charmbracelet/bubbles/list"
+	tea_list "github.com/charmbracelet/bubbles/list"
 	tea "github.com/charmbracelet/bubbletea"
-	"github.com/charmbracelet/lipgloss"
 	"github.com/msteinert/pam/v2"
 	"github.com/ubuntu/authd/internal/brokers/layouts"
 	"github.com/ubuntu/authd/internal/brokers/layouts/entries"
@@ -17,10 +15,8 @@ import (
 
 // authModeSelectionModel is the model list to select supported authentication modes.
 type authModeSelectionModel struct {
-	list.Model
-	focused bool
+	List
 
-	clientType                PamClientType
 	supportedUILayouts        []*authd.UILayout
 	availableAuthModes        []*authd.GAMResponse_AuthenticationMode
 	currentAuthModeSelectedID string
@@ -44,9 +40,6 @@ type authModeSelected struct {
 	id string
 }
 
-// authModeSelectionFocused is the internal event to signal that the auth mode selection view is focused.
-type authModeSelectionFocused struct{}
-
 // selectAuthMode selects current authentication mode.
 func selectAuthMode(id string) tea.Cmd {
 	return func() tea.Msg {
@@ -58,27 +51,8 @@ func selectAuthMode(id string) tea.Cmd {
 
 // newAuthModeSelectionModel initializes an empty list with default options of authModeSelectionModel.
 func newAuthModeSelectionModel(clientType PamClientType) authModeSelectionModel {
-	// FIXME: decouple UI from data model.
-	if clientType != InteractiveTerminal {
-		return authModeSelectionModel{
-			Model:      list.New(nil, itemLayout{}, 0, 0),
-			clientType: clientType,
-		}
-	}
-
-	l := list.New(nil, itemLayout{}, 80, 24)
-	l.Title = "Select your authentication method"
-	l.SetShowStatusBar(false)
-	l.SetShowHelp(false)
-	l.DisableQuitKeybindings()
-
-	l.Styles.Title = lipgloss.NewStyle()
-	/*l.Styles.PaginationStyle = paginationStyle
-	l.Styles.HelpStyle = helpStyle*/
-
 	return authModeSelectionModel{
-		Model:      l,
-		clientType: clientType,
+		List: NewList(clientType, "Select your authentication method"),
 	}
 }
 
@@ -128,10 +102,6 @@ func (m *authModeSelectionModel) Init() tea.Cmd {
 // Update handles events and actions.
 func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea.Cmd) {
 	switch msg := msg.(type) {
-	case authModeSelectionFocused:
-		log.Debugf(context.TODO(), "%T: %#v", m, msg)
-		m.focused = true
-
 	case supportedUILayoutsReceived:
 		log.Debugf(context.TODO(), "%#v", msg)
 		if len(msg.layouts) == 0 {
@@ -147,7 +117,7 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 		log.Debugf(context.TODO(), "%#v", msg)
 		m.availableAuthModes = msg.authModes
 
-		var allAuthModes []list.Item
+		var allAuthModes []tea_list.Item
 		var firstAuthModeID string
 		for _, a := range m.availableAuthModes {
 			if firstAuthModeID == "" {
@@ -167,6 +137,15 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 
 		return m, tea.Sequence(cmds...)
 
+	case listItemSelected:
+		if !m.Focused() {
+			return m, nil
+		}
+
+		log.Debugf(context.TODO(), "%#v", msg)
+		authMode := convertTo[authModeItem](msg.item)
+		return m, selectAuthMode(authMode.id)
+
 	case authModeSelected:
 		log.Debugf(context.TODO(), "%#v", msg)
 		// Ensure auth mode id is valid
@@ -190,76 +169,11 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 		})
 	}
 
-	if m.clientType != InteractiveTerminal {
-		return m, nil
-	}
-
-	// interaction events
-	if !m.focused {
-		return m, nil
-	}
-	switch msg := msg.(type) {
-	// Key presses
-	case tea.KeyMsg:
-		switch msg.String() {
-		case "enter":
-			item := m.SelectedItem()
-			if item == nil {
-				return m, nil
-			}
-			authMode := convertTo[authModeItem](item)
-			cmd := selectAuthMode(authMode.id)
-			return m, cmd
-		case "1", "2", "3", "4", "5", "6", "7", "8", "9":
-			// This is necessarily an integer, so above
-			choice, _ := strconv.Atoi(msg.String())
-			items := m.Items()
-			if choice > len(items) {
-				return m, nil
-			}
-			item := items[choice-1]
-			authMode := convertTo[authModeItem](item)
-			cmd := selectAuthMode(authMode.id)
-			return m, cmd
-		}
-	}
-
 	var cmd tea.Cmd
-	m.Model, cmd = m.Model.Update(msg)
+	m.List, cmd = m.List.Update(msg)
 	return m, cmd
 }
 
-// View renders a text view of the authentication UI.
-func (m authModeSelectionModel) View() string {
-	if !m.Focused() {
-		return ""
-	}
-
-	return m.Model.View()
-}
-
-// Focus focuses this model.
-func (m *authModeSelectionModel) Focus() tea.Cmd {
-	log.Debugf(context.TODO(), "%T: Focus", m)
-	return sendEvent(authModeSelectionFocused{})
-}
-
-// Focused returns if this model is focused.
-func (m *authModeSelectionModel) Focused() bool {
-	return m.focused
-}
-
-// Blur releases the focus from this model.
-func (m *authModeSelectionModel) Blur() {
-	log.Debugf(context.TODO(), "%T: Blur", m)
-	m.focused = false
-}
-
-// WillCaptureEscape returns if this broker may capture Esc typing on keyboard.
-func (m authModeSelectionModel) WillCaptureEscape() bool {
-	return m.FilterState() == list.Filtering
-}
-
 // authModeItem is the list item corresponding to an authentication mode.
 type authModeItem struct {
 	id    string