pam/adapter: Avoid using pointer receivers for Init functions

And other functions where we don't write to the models

Author: 3v1n0

pam/internal/adapter/authentication.go

@@ -174,7 +174,7 @@ func newAuthenticationModel(client authd.PAMClient, clientType PamClientType) au
 }
 
 // Init initializes authenticationModel.
-func (m *authenticationModel) Init() tea.Cmd {
+func (m authenticationModel) Init() tea.Cmd {
 	return nil
 }
 

pam/internal/adapter/authmodeselection.go

@@ -83,7 +83,7 @@ func newAuthModeSelectionModel(clientType PamClientType) authModeSelectionModel
 }
 
 // Init initializes authModeSelectionModel.
-func (m *authModeSelectionModel) Init() tea.Cmd {
+func (m authModeSelectionModel) Init() tea.Cmd {
 	if m.clientType != InteractiveTerminal {
 		// This is handled by the GDM or Native model!
 		return nil

pam/internal/adapter/gdmmodel.go

@@ -43,13 +43,13 @@ type gdmIsAuthenticatedResultReceived isAuthenticatedResultReceived
 type gdmStopConversations struct{}
 
 // Init initializes the main model orchestrator.
-func (m *gdmModel) Init() tea.Cmd {
+func (m gdmModel) Init() tea.Cmd {
 	return tea.Sequence(m.protoHello(),
 		requestUICapabilities(m.pamMTx),
 		m.pollGdm())
 }
 
-func (m *gdmModel) protoHello() tea.Cmd {
+func (m gdmModel) protoHello() tea.Cmd {
 	reply, err := gdm.SendData(m.pamMTx, &gdm.Data{Type: gdm.DataType_hello})
 	if err != nil {
 		return sendEvent(pamError{
@@ -169,13 +169,13 @@ func (m *gdmModel) pollGdm() tea.Cmd {
 	return tea.Sequence(commands...)
 }
 
-func (m *gdmModel) emitEvent(event gdm.Event) tea.Cmd {
+func (m gdmModel) emitEvent(event gdm.Event) tea.Cmd {
 	return func() tea.Msg {
 		return m.emitEventSync(event)
 	}
 }
 
-func (m *gdmModel) emitEventSync(event gdm.Event) tea.Msg {
+func (m gdmModel) emitEventSync(event gdm.Event) tea.Msg {
 	err := gdm.EmitEvent(m.pamMTx, event)
 	log.Debug(context.TODO(), "EventSend", event, "result", err)
 	if err != nil {

pam/internal/adapter/userselection.go

@@ -58,7 +58,7 @@ func newUserSelectionModel(pamMTx pam.ModuleTransaction, clientType PamClientTyp
 }
 
 // Init initializes userSelectionModel.
-func (m *userSelectionModel) Init() tea.Cmd {
+func (m userSelectionModel) Init() tea.Cmd {
 	return nil
 }