Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to ignore static check on helper files #842

Merged
merged 1 commit into from
Mar 19, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/authd/integrationtests.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Should only be built when running integration tests.

//go:build integrationtests

package main
2 changes: 2 additions & 0 deletions internal/services/withexamples.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Should only be built when building authd with the examplebroker enabled for tests.

//go:build withexamplebroker

package services
2 changes: 2 additions & 0 deletions internal/testsdetection/integrationtests.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Should only be built when running integration tests.

//go:build integrationtests

package testsdetection
2 changes: 2 additions & 0 deletions internal/testsdetection/testdata/binary.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Should only be built when running integration tests.

package main

import (
2 changes: 2 additions & 0 deletions pam/generate.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a helper file to generate the pam module easily.

//go:build generate && !pam_module_generation && !pam_debug

//go:generate go generate -C internal/proto
2 changes: 2 additions & 0 deletions pam/generate_debug.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a helper file to generate the pam module easily in debug mode.

//go:build generate && !pam_module_generation && pam_debug

//go:generate go generate -C internal/proto
2 changes: 2 additions & 0 deletions pam/go-exec/module.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This file is compiled indirectly through go generate.

/* A simple PAM wrapper for GO based pam modules
*
* Copyright (C) 2024 Canonical Ltd.
2 changes: 2 additions & 0 deletions pam/integration-tests/cmd/exec-client/client.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a test helper.

//go:build pam_tests_exec_client

// Package main is the package for the exec test client.
2 changes: 2 additions & 0 deletions pam/integration-tests/cmd/exec-client/modulewrapper.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a test helper.

//go:build pam_tests_exec_client

package main
2 changes: 2 additions & 0 deletions pam/integration-tests/sshd_preloader/sshd_preloader.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a test helper.

#define _GNU_SOURCE 1
#include <assert.h>
#include <stdlib.h>
2 changes: 2 additions & 0 deletions pam/internal/gdm/debug.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is only built for tests.

//go:build pam_gdm_debug

package gdm
2 changes: 2 additions & 0 deletions pam/internal/gdm/extension.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Header files are not built by default.

#include <stdlib.h>
#include <string.h>

2 changes: 2 additions & 0 deletions pam/internal/gdm/extensions/gdm-custom-json-pam-extension.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Header files are not built by default.

/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2023 Canonical Ltd.
2 changes: 2 additions & 0 deletions pam/internal/gdm/extensions/gdm-pam-extensions-common.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // Header files are not built by default.

/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2017 Red Hat, Inc.
2 changes: 2 additions & 0 deletions pam/internal/proto/generate.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a helper to compile the proto files.

//go:build generate

//go:generate ../../../tools/generate-proto.sh pam.proto
2 changes: 2 additions & 0 deletions pam/tools/pam-runner/pam-runner.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is a test helper.

//go:build withpamrunner

package main
2 changes: 2 additions & 0 deletions tools/tools.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TiCS: disabled // This is to pin the tools versions that we use.

//go:build tools

package tools