Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up install directory on failure #390

Open
thibran opened this issue Dec 9, 2016 · 1 comment
Open

clean-up install directory on failure #390

thibran opened this issue Dec 9, 2016 · 1 comment

Comments

@thibran
Copy link

thibran commented Dec 9, 2016

In case of a failure when installing something, I would expect umake to clean-up all downloaded files and created folders, restoring somewhat the state pre-umake-installation.

E.g.:
When installing go using umake go to ~/.local/share/umake/go/go-lang, umake should delete ~/.local/share/umake/go/go-lang on failure.

@didrocks
Copy link
Member

This is good and valid, thanks for the suggestion! This could be a good first contributor patch, will use it as such.

There is only one tricky thing to remember for whoever implements this: in case of a reinstall, if the failure happens before unpacking the archive, then, don't remove the directory. We need to decide if the failure happens during unpacking if we moved the initial directory content first to restore it or not (which could be an issue space-wise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants