Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LicensePage #581

Open
Feichtmeier opened this issue Feb 4, 2023 · 4 comments
Open

LicensePage #581

Feichtmeier opened this issue Feb 4, 2023 · 4 comments
Labels
enhancement New feature or request widgets

Comments

@Feichtmeier
Copy link
Member

The flutter license page is really not so good looking but a working master detail page with packages in the master
grafik
and licnese in the detail
grafik

We do not need to change much but at least somehow this appbar

Alternatively it could be made themeable in flutter

opinions @jpnurmi @Jupi007 ?

@Jupi007
Copy link
Member

Jupi007 commented Feb 4, 2023

Looking at the code, I think the licence page isn't themable at all...

But, it looks like you can use LicenseRegistry.licenses which returns all licenses as a stream.
Maybe should we create a yaru_widget license page, as this will be used all our apps?

Btw, this would allow to replace this material back arrow by a yaru one 😈

@Feichtmeier
Copy link
Member Author

Looking at the code, I think the licence page isn't themable at all...

But, it looks like you can use LicenseRegistry.licenses which returns all licenses as a stream.
Maybe should we create a yaru_widget license page, as this will be used all our apps?

Btw, this would allow to replace this material back arrow by a yaru one 😈

That would be cool.

@jpnurmi
Copy link
Member

jpnurmi commented Feb 4, 2023

Did you try populating YaruMasterDetailPage with LicenseRegistry? :)

@Feichtmeier
Copy link
Member Author

No. Worth a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request widgets
Projects
None yet
Development

No branches or pull requests

3 participants