Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruBackButton alignment behavior is inconsistent #891

Open
d-loose opened this issue Apr 30, 2024 · 7 comments
Open

YaruBackButton alignment behavior is inconsistent #891

d-loose opened this issue Apr 30, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@d-loose
Copy link
Member

d-loose commented Apr 30, 2024

Depending on whether its style is round or not, the button is wrapped in a Center() widget (see #531). Consequently, ubuntu/app-center#1622 lead to a misalignment in the App Center's search page:
image

Of course, this can be fixed very easily, but I suppose it's worth making the behavior consistent in yaru 🙂

@spydon
Copy link
Collaborator

spydon commented May 7, 2024

Ideally, doesn't this look better?

image

@Feichtmeier
Copy link
Member

It should be in the leading spot of the appbar, when the page is paned, IMO, just like in the yaru.dart example :) or in the firmware updater / settings app / musicpod / etc
Not to distract from the actual issue, but the back button placement was really questionable from the beginning, IMHO 🙏

@spydon
Copy link
Collaborator

spydon commented Jul 1, 2024

It should be in the leading spot of the appbar, when the page is paned, IMO, just like in the yaru.dart example

That sounds like I good idea, but I can't find that in the yaru example?
Can you send a screenshot?

@Feichtmeier
Copy link
Member

It should be in the leading spot of the appbar, when the page is paned, IMO, just like in the yaru.dart example

That sounds like I good idea, but I can't find that in the yaru example?
Can you send a screenshot?

I just had a local change with this back button in the _TitleBar but got confused by the many ways in app center to access the navkey and reverted it

It could look like in this picture in MusicPod, but then on the snap/deb pages the share and flag buttons need to be moved I suppose

album_dark.png

@spydon
Copy link
Collaborator

spydon commented Jul 1, 2024

That looks a lot better indeed, what do you think @anasereijo?

@anasereijo
Copy link

Indeed! This can work well now that we have approved @Feichtmeier's changes to the layout of the side nav. I am happy to proceed with this, make sure it's present on all pages that can have the back button (search results, app page, etc).

@Feichtmeier
Copy link
Member

The issue remains but when I read Taha Tesser correctly, this issue with flutters leading widget in app bars is fixed, I think we can removed this internal center here, I'll have a look

@Feichtmeier Feichtmeier self-assigned this Oct 28, 2024
@Feichtmeier Feichtmeier added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants