Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of sample when running multi-tumor patients in paired mode with a single normal #149

Open
yashpatel6 opened this issue Nov 22, 2023 · 1 comment
Assignees

Comments

@yashpatel6
Copy link
Collaborator

          > The deletion doesn't actually change any behavior at all in the metapipeline; the metapipeline already greedily takes the first normal BAM and uses it while ignoring the others when running multi-tumor patients in paired mode. Also, the deletion is only happening under /scratch, the final output directory still contains all of the normal BAMs generated in their respective output directories.

The change here is purely to clean up /scratch by removing files that are already not being used further in the metapipeline

Got it. End users might want to rerun somatic pipelines retrospectively if the specific normal sample has potential issues, especially when the normal processed with mets samples was used while primary one is available. It would be useful to eventually have an option to choose which normal sample to use.

Originally posted by @tyamaguchi-ucla in #139 (comment)

@yashpatel6 yashpatel6 self-assigned this Nov 22, 2023
@yashpatel6
Copy link
Collaborator Author

          Agreed, I figure it hasn't been a huge issue so far since this only applies when run with a specific combination of samples and run mode; if multi-tumor samples are run in multi mode or if the normal-tumor samples are explicitly paired and then run in paired mode, this behavior should have no effect. I'll add an issue for allowing users to choose for that specific case though!

Originally posted by @yashpatel6 in #139 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant