Rocq 9.0 #24
Closed
Rocq 9.0 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge-fixpoint-cofixpoint Adapt to change of type of VernacFixpoint in Coq PR #19107
TheoWinterhalter
force-pushed
the
rocq-9.0
branch
from
a078bde to
15803c7
Compare
Contributor
Author
|
CI is now green on my fork. |
Contributor
|
Last time I compiled the case studies (on 8.20) there was a lot of noisy warnings, did you get rid of these too? |
Contributor
Author
|
There are some warnings indeed. I can fix them. |
Contributor
Author
|
I fixed those that were easy to fix, but not some related to |
Contributor
|
Thanks for taking care of it! I guess it's fine if there are some left, we can always wait to when the warnings turn into errors (or the semantic change happen). |
Contributor
Author
|
The ones that are left are just incompatibilities between notations, unrelated to Rocq versions. |
Contributor
|
Yeah, this can wait until we muster the will to clean-up the notation/typeclass mess ^^' |
Member
|
Thanks a lot! The branch is here now: https://github.com/uds-psl/autosubst-ocaml/tree/rocq-9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to port to Rocq 9.0, including a renaming of the package.
Most of those changes would need to be ported to
mastertoo.I guess compatibility with older versions of Coq could be dropped at this point.