move notations into module #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@JoJoDeveloping Please have a look at PR #229 that does precisely that among other things. It was only merged in |
Contributor
Author
|
Oh, thanks for the hint. That seems to do the trick, sad that it's not available on 8.20 yet. So I guess we just wait until you're updated to 9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notation is reserved and only used in some parts of the development. But since it is still globally reserved, importing
vec.vstill produces warnings about clashing notations. A proper fix is to move these notations into a module.This is a first draft, presumably the definition should also be moved into such a module so that one does not have to re-define the notation elsewhere.
Making the notation no longer globally enabled would be great because it otherwise clashes with the ones defined in FOL/Syntax/SyntacticOps.v.