Remove ill-placed notation definitions from FOL Friedman translation #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the CI failure is not because of me, but because the docker container's user is now called |
Collaborator
|
Is it possible to coordinate this with #232, e.g. as a pull request for DmxLarchey:notation-overridden-2? |
Contributor
Author
|
Pr #232 also fixes this issue, but it might still be good to remove these notations here anyway since they are not needed. |
DmxLarchey
added a commit
to DmxLarchey/coq-library-undecidability
that referenced
this pull request
Feb 27, 2025
Collaborator
|
Integrated in #232. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that putting these notations here is a bad idea for coq-library-fol. In particular,
-follikes to tweak these notations in various places which leads to overridden notation warnings. Fixing them is mostly downstream but requires that these notations are removed here.