Skip to content

Commit 5307bd8

Browse files
authored
Fix issue with updating both config & tree value (#1190)
* fix * chlog
1 parent 811054e commit 5307bd8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# Changelog
2+
- 6.6.11
3+
- Fix issue with updating both config & tree value (PR #1190) (issue #1187)
24
- 6.6.10
35
- Fix escape/unescape for LIKE operator (PR #1177) (issue #982)
46
- Fix tags tokenization (antd) (PR #1182) (issue #1115)

packages/ui/modules/components/QueryContainer.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ export default class QueryContainer extends Component {
9696
const currentTree = isTreeChanged ? (nextProps.value || defaultRoot(nextProps)) : storeValue;
9797
const isTreeTrulyChanged = isTreeChanged && !immutableEqual(nextProps.value, this.prevTree) && !immutableEqual(nextProps.value, this.prevprevTree);
9898
this.sanitizeTree = isTreeTrulyChanged || isConfigChanged;
99+
const canUseOldConfig = isConfigChanged && !isTreeChanged;
99100

100101
if (isConfigChanged) {
101102
if (prevProps.settings.renderProvider !== nextProps.settings.renderProvider) {
@@ -105,7 +106,7 @@ export default class QueryContainer extends Component {
105106
}
106107

107108
if (isTreeChanged || isConfigChanged) {
108-
const validatedTree = this.getMemoizedTree(nextConfig, currentTree, oldConfig, this.sanitizeTree);
109+
const validatedTree = this.getMemoizedTree(nextConfig, currentTree, canUseOldConfig ? oldConfig : undefined, this.sanitizeTree);
109110
//return Promise.resolve().then(() => {
110111
this.state.store.dispatch(
111112
actions.tree.setTree(nextConfig, validatedTree)

0 commit comments

Comments
 (0)