[NODRIVER] Potential Memory Leak In connection.mapper

[patricksuo]

event in connection.mapper never got del?

https://github.com/ultrafunkamsterdam/nodriver/blob/ebcda701a48e1c320b80c86af2b128098aeb837f/nodriver/core/connection.py#L643-L649

[ultrafunkamsterdam]

event in connection.mapper never got del?

https://github.com/ultrafunkamsterdam/nodriver/blob/ebcda701a48e1c320b80c86af2b128098aeb837f/nodriver/core/connection.py#L643-L649

Pending update has this fixed and clears mapper on each request. This way it will only conctain events received during the request.

[patricksuo]

Pending update has this fixed and clears mapper on each request. This way it will only conctain events received during the request

I took a look at the send code, and it seems like it adds more tx to the mapper without clearing it beforehand.

            tx = Transaction(cdp_obj)
            tx.connection = self
            if not self.mapper:
                self.__count__ = itertools.count(0)
            tx.id = next(self.__count__)
            self.mapper.update({tx.id: tx}) # <----- adding more tx, but I can't find the clear code
            if not _is_update:
                await self._register_handlers()

[ultrafunkamsterdam]

https://github.com/ultrafunkamsterdam/nodriver/blob/960845fb57bafb7de308b5ecce38ec367fdbb68d/nodriver/core/connection.py#L422

[patricksuo]

Thanks for the fix.

Two more following questions:

1. I think it's better to keep tx id monotonic. just in case the id is used/ref in caller side.
2. What is the use case of the EventTransation? An event is consume immediately by registered event handlers.

            tx = Transaction(cdp_obj)
            tx.connection = self
            # if not self.mapper:
            if not _is_update:
                self.mapper.clear()
                self.__count__ = itertools.count(0) <----- I think it's better to keep tx id monotonic

            tx.id = next(self.__count__)
            self.mapper.update({tx.id: tx})
            if not _is_update:
                await self._register_handlers()
            await self.websocket.send(tx.message)