hotfix: 17434 (prevent routable modals inside not routable modals) #2518
+121
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent context consumption of route-context from a modal that is not routable. Making routableModals never construct a path and thereby not valid.
This is breaking in the sense if someone wanted to retrieve the Route Context from a not-routable-modal. But this is not what we want pr. default.
If you still like to do so you have to consume the context with
.passContextAliasMatches()
enabled on your consumption.fixes umbraco/Umbraco-CMS#17434
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist