-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduction of ECCV'18 paper #26
Comments
Hi @mdouze, Thanks for your interest in our research.
Sorry, this is totally my fault, since I have not had the time to build a complete demo for end users. I'll work on this and by the end of this week post an update. Cheers, |
Hi again @mdouze, I managed to fix the particular demo in your gist, and you should be able to run it with Julia 1.0 -- apparently the language changed waaay more than I anticipated. I ran my ECCV experiments on Julia 0.6... I'll keep working on fixing other demos and keep you posted. Hopefully won't take too long :) Thanks for your patience, |
Update: Pushed a few changes that have fixed the PQ, OPQ, RVQ and ERVQ demos. It'll take me a few more days to fix the LSQ and LSQ++ ones. |
Thanks a lot @una-dinosauria! |
I understand. Sorry about that! I pushed a few changes to fix Chain quantization (GPU support included) today. Hopefully by tomorrow night I'll have LSQ/LSQ++ working again.
Julia 0.6.4 is quite a pain to set up with CUDA, because it requires compiling Julia from source. Cheers and thanks again you for your patience, |
Julia does not seem to be backward compatible, so Julia 1.x is not an option for the local-search-quantization repo. This is why I appreciate that you do the effort for the this repo! Cheers |
Managed to fix LSQ today, except that I'm running into OOM errors in the GPU, probably due to JuliaGPU/CuArrays.jl#152. I'm pretty sure it's related to the memory pool in CuArrays.jl because I distinctly remember having to downgrade my package version to avoid the issue. I kinda hoped someone else would run into it and that it would get fixed In The Future When All Is Well™ -- yet here we are! Unfortunately, upstreaming my use case to Cuarrays.jl is not trivial. So either I'll wait for an answer from the repo maintainer or move to a simpler CUDAdrv.jl-only approach, which has a simple memory management pipeline (see https://discourse.julialang.org/t/freeing-memory-in-the-gpu-with-cudadrv-cudanative-cuarrays/10946/3). |
Thanks! Will try it out... |
Yep! Clarified the README a little bit. Hopefully that will be enough to run LSQ. |
Hi @mdouze, Sorry for the delay and thanks again for your patience I've updated the code, I've tested this on a machine with a TitanXp GPU. I keep getting OOM errors on a GTX 1080, and I've raised the issue with the Please let me know if you run into any issues. PS: I have some things left to do to achieve push-button reproduction of the paper; I've opened a issue #29 to track this. I hope to close this in the coming weeks. |
Hi!
I would like to reproduce the recall@1 vs. time plots in the LSQ++ paper. Thanks for the open-sourcing of the corresponding code!
Installing Julia 0.7 and the Rayuela.jl was relatively painless. However, it is not obvious what the entry point in the code should be.
For example, trying to use a function from demo.jl gives
https://gist.github.com/mdouze/05161b06a3c524cd0955e99a378507a0
--> loading the data is fine and running the training is ok but there seems to be a missing function qerror, which makes me think that this probably not the right entry point.
Sorry, I am not familiar with Julia.
Any help is appreciated!
The text was updated successfully, but these errors were encountered: