-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssl-certificate): get ssl certificate support proxy #961
base: next
Are you sure you want to change the base?
feat(ssl-certificate): get ssl certificate support proxy #961
Conversation
here is test script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wakaka6 @unclecode I'm not very familiar with SSL certificate related concepts or PySocks library. So I'm not in a position to properly review this right away, but I'll do by next alpha release.
I just had a question w.r.t the dependancy, please check that out.
@@ -43,6 +43,7 @@ dependencies = [ | |||
"faust-cchardet>=2.1.19", | |||
"aiohttp>=3.11.11", | |||
"humanize>=4.10.0", | |||
"PySocks @ git+https://github.com/amirasaran/PySocks.git@3da955fd212ce02c3ab3bc166b5bfac3c91b4019" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wakaka6 Could you explain why you're using a direct Git reference with a specific commit hash instead of the official PyPI package?
faust-cchardet>=2.1.19 | ||
PySocks @ git+https://github.com/amirasaran/PySocks.git@3da955fd212ce02c3ab3bc166b5bfac3c91b4019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why you're using a direct Git reference with a specific commit hash instead of the official PyPI package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The official Pysocks has buggy(Anorov/PySocks#147) support for http proxies and the original author doesn't seem to have maintained it for a long time as well, so i need to use a specific version of Pysocks as a dependency.
Fixes: #778 - Tagging for visibility |
Summary
Support proxy when getting ssl certificate
Same as #864 PR, but based on next branches.
List of files changed and why
ssl_ceritficate.py
ssl_ceritificate.to_playwright_format()
str(ssl_ceritificate)
proxy_config.py
self.username
andself.password
.async_crawler_strategy.py
How Has This Been Tested?
Checklist: