Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom template isn't aligned #77

Open
kaihendry opened this issue Mar 8, 2019 · 2 comments
Open

Custom template isn't aligned #77

kaihendry opened this issue Mar 8, 2019 · 2 comments
Assignees

Comments

@kaihendry
Copy link
Contributor

https://github.com/unee-t/bugzilla-customisation/tree/master/custom & https://github.com/bugzilla/bugzilla/tree/5.0/template/en/default have diverged

[hendry@t480s custom]$ grep -r field.js .
./bug/summarize-time.html.tmpl:    javascript_urls = [ "js/util.js", "js/field.js" ]
./bug/create/create.html.tmpl:                      "js/field.js", "js/TUI.js", "js/bug.js" ]
./search/search-advanced.html.tmpl:  javascript_urls = [ "js/util.js", "js/TUI.js", "js/field.js"]
./attachment/create.html.tmpl:  javascript_urls = [ "js/attachment.js", 'js/field.js', "js/util.js", "js/TUI.js" ]
./list/list.html.tmpl:  javascript_urls = [ "js/util.js", "js/field.js", "js/TUI.js" ]
./admin/components/edit.html.tmpl:  javascript_urls = [ "js/field.js" ]
./admin/components/create.html.tmpl:  javascript_urls = [ "js/field.js" ]
./admin/products/create.html.tmpl:  javascript_urls = ['js/util.js', 'js/field.js']
[hendry@t480s custom]$ grep -r field.js /tmp/bugzilla/template/en/default
/tmp/bugzilla/template/en/default/search/search-report-table.html.tmpl:  javascript_urls = [ "js/util.js", "js/TUI.js", "js/field.js" ]
/tmp/bugzilla/template/en/default/search/search-report-graph.html.tmpl:  javascript_urls = [ "js/util.js", "js/TUI.js", "js/field.js" ]
/tmp/bugzilla/template/en/default/search/search-create-series.html.tmpl:  javascript_urls = [ "js/util.js", "js/TUI.js", "js/field.js" ]
/tmp/bugzilla/template/en/default/search/search-advanced.html.tmpl:  javascript_urls = [ "js/util.js", "js/TUI.js", "js/field.js"]
/tmp/bugzilla/template/en/default/request/queue.html.tmpl:  javascript_urls=["js/productform.js", "js/field.js"]
/tmp/bugzilla/template/en/default/list/list.html.tmpl:  javascript_urls = [ "js/util.js", "js/field.js", "js/TUI.js" ]
/tmp/bugzilla/template/en/default/bug/summarize-time.html.tmpl:    javascript_urls = [ "js/util.js", "js/field.js" ]
/tmp/bugzilla/template/en/default/bug/show-header.html.tmpl:[% javascript_urls = [ "js/util.js", "js/field.js" ] %]
/tmp/bugzilla/template/en/default/bug/create/create.html.tmpl:                      "js/field.js", "js/TUI.js", "js/bug.js" ]
/tmp/bugzilla/template/en/default/attachment/edit.html.tmpl:  javascript_urls = ['js/attachment.js', 'js/field.js']
/tmp/bugzilla/template/en/default/attachment/create.html.tmpl:  javascript_urls = [ "js/attachment.js", 'js/field.js', "js/util.js", "js/TUI.js" ]
/tmp/bugzilla/template/en/default/admin/users/edit.html.tmpl:  javascript_urls = [ 'js/field.js' ]
/tmp/bugzilla/template/en/default/admin/products/create.html.tmpl:  javascript_urls = ['js/util.js', 'js/field.js']
/tmp/bugzilla/template/en/default/admin/components/edit.html.tmpl:  javascript_urls = [ "js/field.js" ]
/tmp/bugzilla/template/en/default/admin/components/create.html.tmpl:  javascript_urls = [ "js/field.js" ]
/tmp/bugzilla/template/en/default/account/prefs/prefs.html.tmpl:   javascript_urls = ['js/util.js', 'js/field.js', 'js/TUI.js']

Symptom is that calendar button doesn't work since there is no reference to /js/field.js
https://media.dev.unee-t.com/2019-03-08/diffstat.txt
https://media.dev.unee-t.com/2019-03-08/custom.mp4

There appears to be some "LMB" modifications in the custom.

@franck-boullier
Copy link
Member

franck-boullier commented Mar 8, 2019

@kaihendry I know we spoke about creating a working vanilla BZ instance somewhere so I can work on these issues and make sure we have an easy way to identify the differences between the current stable version of BZ and unee-t.

@kaihendry, where can I find the credentials to access this instance (ideally FTP access, SSH access and DB access)

@kaihendry
Copy link
Contributor Author

I noticed the calendar function is there, but it's not rendering for some reason or another. https://media.dev.unee-t.com/2019-03-08/debugging.mp4

So it might not be a template issue. Not entirely sure. Nonetheless the templates are divergent.

I would prefer not to have JS operating on the forms and use https://html.spec.whatwg.org/multipage/input.html#date-state-(type=date) instead, but that only works in Chrome at time of writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants