Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and Sample variables are making dangerous assumptions #17

Open
franck-boullier opened this issue Feb 1, 2020 · 1 comment
Open

Comments

@franck-boullier
Copy link
Member

The problem:

The files main_test.go and tests/sample.json are assuming that there is:

  • an existing user in the installation with the BzUserId = 55
  • an existing Classification in the BZ installation with classificationId = 2

This might not always be true.

The fix:

  • In the BZ seed script when we create a BZ installation from scratch, we need to create a specific user for tests.
  • This repo should use this specifically created user for tests.
@franck-boullier
Copy link
Member Author

One consequence of this issue seems to be that the build on Pushed branches from Travis CI will always fail.
The temporary fix is to configure Travis CI to build only on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant