Skip to content

Commit 79fc53b

Browse files
committed
simplify dry run
1 parent 14de47d commit 79fc53b

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44
This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).
55

6-
## [Unreleased]
6+
## [1.1.2] - 2015-03-09
77
* add `dry-run` and `workpath` options
88
* add a `get-defaults.js` test
9-
* improve change log
9+
* check if commit exists on github before trying to create release [#11](https://github.com/ngoldman/gh-release/issues/11)
10+
* add support for git URLs [#16](https://github.com/ngoldman/gh-release/issues/16)
1011

1112
## [1.1.1] - 2015-03-02
1213
* use `changelog-parser` for more reliable change log parsing
@@ -56,7 +57,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
5657
* define basic node interface
5758
* define basic cli interface
5859

59-
[Unreleased]: https://github.com/ngoldman/gh-release/compare/v1.1.1...HEAD
60+
[1.1.2]: https://github.com/ngoldman/gh-release/compare/v1.1.1...v1.1.2
6061
[1.1.1]: https://github.com/ngoldman/gh-release/compare/v1.1.0...v1.1.1
6162
[1.1.0]: https://github.com/ngoldman/gh-release/compare/v1.0.8...v1.1.0
6263
[1.0.8]: https://github.com/ngoldman/gh-release/compare/v1.0.7...v1.0.8

index.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ var questions = [
2222
]
2323

2424
function ghRelease (options, auth, callback) {
25-
// save dry run value then remove from options
26-
var dryRun = options.dryRun
27-
delete options.dryRun
28-
2925
if (auth && auth.token) {
3026
client.authenticate({
3127
type: 'oauth',
@@ -48,7 +44,7 @@ function ghRelease (options, auth, callback) {
4844

4945
console.log(releaseOptions)
5046

51-
if (dryRun) process.exit(0)
47+
if (options.dryRun) process.exit(0)
5248

5349
inquirer.prompt(questions, function (answers) {
5450
if (!answers.confirm) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "gh-release",
33
"description": "Create a release for a node package on github.",
4-
"version": "1.1.1",
4+
"version": "1.1.2",
55
"author": "Nate Goldman <[email protected]>",
66
"bin": {
77
"gh-release": "./bin/cli.js"

0 commit comments

Comments
 (0)