Skip to content

Commit db64d52

Browse files
jrmykolynungoldman
authored andcommitted
catch 'bracketed' unreleased changelog entries (eg. '[Unreleased]'); update tests (#66)
1 parent 496c9aa commit db64d52

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

bin/lib/get-defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function getDefaults (workPath, callback) {
2121

2222
var unreleased = result.versions.filter(function (release) {
2323
return release.title && release.title.toLowerCase
24-
? release.title.toLowerCase() === 'unreleased'
24+
? release.title.toLowerCase().indexOf('unreleased') !== -1
2525
: false
2626
})
2727

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
## [Unreleased]
2+
3+
## 1.0.0
4+
- bananas
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"name": "gh-release-test",
3+
"version": "1.0.0",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/bcomnes/gh-release-test.git"
7+
}
8+
}

test/index.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,15 @@ test('should return error if changelog version !== package.json version', functi
2222
})
2323

2424
test('should return error if unreleased section exists', function (t) {
25-
t.plan(1)
25+
t.plan(2)
2626
ghRelease({
2727
workpath: fixture('unreleased')
2828
}, function (err, result) {
2929
t.deepEqual(err.message, 'Unreleased changes detected in CHANGELOG.md, aborting')
3030
})
31+
ghRelease({
32+
workpath: fixture('unreleased-alt')
33+
}, function (err, result) {
34+
t.deepEqual(err.message, 'Unreleased changes detected in CHANGELOG.md, aborting')
35+
})
3136
})

0 commit comments

Comments
 (0)