Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository maintenance #301

Open
networkException opened this issue Jun 15, 2022 · 13 comments
Open

Repository maintenance #301

networkException opened this issue Jun 15, 2022 · 13 comments

Comments

@networkException
Copy link
Member

This repository is currently unmaintained, as such we are considering to add people to the team as described in https://github.com/ungoogled-software/ungoogled-chromium/blob/master/docs/repo_management.md#teams-in-the-ungoogled-software-organization with access to this repository.

@berkley4 you've been maintaining an active fork of this repository with some modifications, would you be willing to manage the updates here?

I think changes to the build system and debian specific patches could be moved here as is, for some things upstreaming to the ungoogled-chromium patchset might be beneficial and some things are probably better to only keep in a fork (eg. google translate integration)

See also ungoogled-software/ungoogled-chromium-windows#144

@ghost
Copy link

ghost commented Jun 17, 2022

Go ahead. I've basically had to give up on this because I couldn't figure out some critical issues people kept reporting.

@Eloston
Copy link
Member

Eloston commented Jun 21, 2022

I'm okay to make unportable the default branch. I semi-regularly update this branch because it's what I personally use, though I'm happy to let someone else take over who wants to update more regularly. To make things easier for maintenance and CD, we could make a subset of that branch that excludes some extras I included like (attempted) VA-API support.

The complication with automation at this stage is it requires an updated LLVM compiler (due to being a wrapper around Portable Linux). AFAIK it isn't easy to make OBS happy with this, so we'd want to switch to another solution.

@networkException
Copy link
Member Author

I sadly don't have time in the next few weeks to look into all this so any improvements are very welcome

I'm okay to make unportable the default branch

That's probably the best for now to avoid the critical issues

@ghost
Copy link

ghost commented Jul 5, 2022

I am going to try one last time to resolve the issues with the packaging. I'll see what I can do after I finish the upgrade to 103.

@ghost
Copy link

ghost commented Jul 7, 2022

It builds now.

@bonswouar
Copy link

I can confirm it builds, I've successfully built locally the latest ungoogled-chromium from upstream.
Although it seems than some changes of the build process from @berkley4 can be interesting, not sure what approach would be the best?

I don't know much about CI/CD for debian packages, but if I can be of any help please don't hesitate. Imo this really needs to be maintained, having to build the package yourself (or use flatpak) isn't a great solution...

@ghost
Copy link

ghost commented Jul 23, 2022

Last I tried this the resulting builds had some serious JavaScript performance issues that I couldn't trace. If someone else can figure out what that issue is I would greatly appreciate it.

@bonswouar
Copy link

By "serious JavaScript performance issues" do you mean can't load any page? Because I've just noticed that's what happens on my install (empty tabs just keep loading forever) 😅

Not sure how to figure that out though

@ghost
Copy link

ghost commented Jul 23, 2022

The test case involved slow import of rules for uMatrix extension. It's in another reported issue.

@ghost
Copy link

ghost commented Apr 10, 2023

Seems to be resolved with current release but should we be looking for someone else to do future updates?

@networkException
Copy link
Member Author

I think at least two maintainers who can approve each other's changes would be great but if you have some capacity to keep this updated then I wouldn't say its strictly necessary to find more people

@jonhermansen
Copy link

Hi, I would like to help maintain and keep the Debian package up to date with upstream.

What can I do to help?

@networkException
Copy link
Member Author

I would encourage you to play with the tooling and see if you can update to the latest ungoogled-chromium release. Perhaps #328 can be a starting point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants