From 7b1c4dbf90f5181fa8d970aa3d9bd7084265f470 Mon Sep 17 00:00:00 2001
From: Craig Cornelius
Date: Wed, 17 Jul 2024 16:25:20 -0700
Subject: [PATCH 01/26] Add known issues result type to verification (#253)
* Add plural rules to CPP
* Add the Rust datetime fmt code
* Rust datetime fmt and updates to ICU4C and NodeJS (#240)
* Add plural rules to CPP
* Starting ICU4X datetime fmt
* DateTime format: Set default timezone explicitly
* Fix formatting
* Added ICU4X timezone computation - not working yet!
* DateTime generator updated to ISO formatted string
* DateTime updates for Node and ICU4C.
* Formatted src/datetimefmt.rs
* Updated using CustomTimeZone in ICU4X date time fmt
* Cargo clippified
* Remove unused function
* Update version to ~1.3
* Adding known issues to reports
* Fixing comment
* removing extra file
* Structured for known issues in reports
* Updated summary page with known issues color
* Fix typo
* Fixes to testreports
---
verifier/detail_template.html | 64 +++++++++--
verifier/report_template.py | 16 ++-
verifier/summary_template.html | 8 +-
verifier/testreport.py | 200 ++++++++++++++++++++++++---------
verifier/verifier.py | 1 -
5 files changed, 224 insertions(+), 65 deletions(-)
diff --git a/verifier/detail_template.html b/verifier/detail_template.html
index 0a0f7db4..9c89cae4 100644
--- a/verifier/detail_template.html
+++ b/verifier/detail_template.html
@@ -84,6 +84,8 @@
.class_error tr:hover {background-color: #ffdd00;}
.class_unsupported th {background-color: #777777;}
.class_unsupported tr:hover {background-color: #dddddd;}
+.class_known_issue th {background-color: #dd8200;}
+.class_known_issue tr:hover {background-color: #dd8200;}
.class_selected_fails th {background-color: #0000ee;}
@@ -142,7 +144,18 @@
widget_label_sets: [],
box_labels: [],
selected_set: null,
+ },
+ 'known_issue': {
+ json: null,
+ all_labels: new Set(),
+ count: 0,
+ characterized: null,
+ check_boxes: [],
+ widget_label_sets: [],
+ box_labels: [],
+ selected_set: null,
}
+
};
// Get the JSON data from the tests.
@@ -153,11 +166,13 @@
let p2 = fetch('./failing_tests.json');
let p3 = fetch('./test_errors.json');
let p4 = fetch('./unsupported.json');
+ let p5 = fetch('./known_issues.json');
let p_pass_char = fetch('./pass_characterized.json');
let p_fail_char = fetch('./fail_characterized.json');
let p_error_char = fetch('./error_characterized.json')
let p_unsupported_char = fetch('./unsupported_characterized.json')
+ let p_known_issue_char = fetch('./known_issues_characterized.json')
// Synchronize all the data loading and charts / pagination
Promise.all([
@@ -173,8 +188,12 @@
p4.then((response) => response.json())
.then((data) => {
test_results['unsupported'].json = data}),
-
- // TODO: Make a separate promise.all for this?
+ p5.then((response) => response.json())
+ .then((data) => {
+ test_results['known_issue'].json = data}),
+
+
+ // TODO: Make a separate promise.all for this?
p_pass_char.then((response) => response.json())
.then((data) => {
test_results['pass'].characterized = data}),
@@ -187,11 +206,14 @@
p_unsupported_char.then((response) => response.json())
.then((data) => {
test_results['unsupported'].characterized = data}),
+ p_known_issue_char.then((response) => response.json())
+ .then((data) => {
+ test_results['known_issue'].characterized = data}),
new Promise((resolve, reject) => {
$(document).ready(resolve);
})
- ]).then(([p1, p2, p3, p4, _ready]) => {
+ ]).then(([p1, p2, p3, p4, p5, _ready]) => {
// Load the Visualization API and the corechart package.
google.charts.load('current', {'packages':['corechart']});
// Set a callback to run when the Google Visualization API is loaded.
@@ -210,8 +232,9 @@
['Passing', test_results['pass'].json.length, '#44ff77'],
['Failing', test_results['fail'].json.length, '#ff0000'],
['Errors', test_results['error'].json.length, '#ffdd00'],
- ['Unsupported', test_results['unsupported'].json.length, '#777777']
- ];
+ ['Unsupported', test_results['unsupported'].json.length, '#777777'],
+ ['Known issues', test_results['known_issue'].json.length, '#ff8200']
+ ];
const chart = new google.visualization.BarChart(chart_output_area);
let chart_data = google.visualization.arrayToDataTable(input_data);
if (chart && chart_data) {
@@ -368,7 +391,7 @@
function onloadFn() {
// Set up for pagination of each set of results
// Do this for each class of results.
- const container_types = ['pass', 'fail', 'error', 'unsupported'];
+ const container_types = ['pass', 'fail', 'error', 'unsupported', 'known_issue'];
let total_summary_count = 0;
for (c_type of container_types) {
let container_type = c_type;
@@ -416,6 +439,7 @@
create_widget_area('fail', create_tristate_area);
create_widget_area('error', create_tristate_area);
create_widget_area('unsupported', create_tristate_area);
+ create_widget_area('known_issue', create_tristate_area);
}
function fill_pagination(pagination_container_name,
@@ -648,7 +672,8 @@ $platform_info
$total_tests attempted. Pass: $passing_tests,
Fail: $failing_tests,
Errors: $error_count,
- Unsupported: $unsupported
+ Unsupported: $unsupported,
+ Known issues: $unsupported
@@ -767,6 +792,31 @@ Test Errors ($error_count)
+
+
+ Known issues ($known_issue_count)
+
+
+
+
+ Known issues characterized
+
+
+
Filtered count = 0
+
+
+
+
+
+
+
+
+
+
+