Rust likely_subtags: categorize"minimizeFavorRegion" as "unsupported" (…

…#114) * Rust number format: mark scientific as unsupported * Reformat numberfmt.rs * ICU4X: move 'minimizeFavorRegion' requests to 'unsupported' * Format rust source
unicode-org · Oct 18, 2023 · ccbff3d · ccbff3d
1 parent 2f9c0ab
commit ccbff3d
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/executors/rust/src/likelysubtags.rs b/executors/rust/src/likelysubtags.rs
@@ -23,6 +23,16 @@ pub fn run_likelysubtags_test(json_obj: &Value) -> Result<Value, String> {
 
     let mut locale = Locale::from_str(locale_str).unwrap();
 
+    if test_option == &"minimizeFavorRegion" {
+        // This option is not yet supported.
+        return Ok(json!({
+            "label": label,
+            "error_detail": {"option": test_option},
+            "unsupported": "minimizeFavorRegion",
+            "error_type": "unsupported",
+        }));
+    }
+
     if test_option == &"minimize" {
         lc.minimize(&mut locale);
     } else if test_option == &"maximize" {

diff --git a/schema/check_schemas.py b/schema/check_schemas.py
@@ -90,8 +90,8 @@ def main(args):
                                       "error_info": str(err)
                                       })
             if not result:
-                schema_errors.append([schema_file_path, result, err, file_path])
-                logging.error('Bad Schema at %s', schema_file_path)
+                schema_errors.append([schema_file, result, err, file_path])
+                logging.error('Bad Schema at %s', schema_file)
             schema_count += 1
 
     ok = val_schema.save_schema_validation_summary(validation_status)

diff --git a/schema/likely_subtags/result_schema.json b/schema/likely_subtags/result_schema.json
@@ -112,11 +112,27 @@
          "error_message": {
            "description": "What went wrong",
            "type": "string"
+         },
+         "error_detail": {
+           "description": "more information on the failure",
+           "type": "object",
+           "properties": {
+             "option": {
+               "description": "Parameters causing the failure",
+               "type": "string",
+               "enum": ["minimizeFavorRegion"]
+             }
+           }
+         },
+         "error_type": {
+           "description": "",
+           "type": "string",
+           "enum": ["unsupported"]
          }
        },
        "required": [
          "label"
-       ]       
+       ]
      }
    }
  }