Skip to content

Commit

Permalink
Add typescript definitions
Browse files Browse the repository at this point in the history
* Add type definitions, `dtslint`, type tests, and expose types in `package.json`
* Add docs for `.data()` without arguments
* Format readme

Closes GH-43.

Reviewed-by: Titus Wormer <[email protected]>
Reviewed-by: Christian Murphy <[email protected]>

Co-authored-by: Hernan Rajchert <[email protected]>
  • Loading branch information
2 people authored and wooorm committed Dec 13, 2018
1 parent 7dc311b commit 7ee2c8f
Show file tree
Hide file tree
Showing 6 changed files with 435 additions and 6 deletions.
11 changes: 9 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@
"contributors": [
"Titus Wormer <[email protected]> (https://wooorm.com)"
],
"types": "types/index.d.ts",
"files": [
"types/index.d.ts",
"index.js",
"lib"
],
"dependencies": {
"@types/unist": "^2.0.0",
"@types/vfile": "^3.0.0",
"bail": "^1.0.0",
"extend": "^3.0.0",
"is-plain-obj": "^1.1.0",
Expand All @@ -34,22 +38,25 @@
},
"devDependencies": {
"browserify": "^16.0.0",
"dtslint": "^0.4.1",
"esmangle": "^1.0.0",
"nyc": "^13.0.0",
"prettier": "^1.12.1",
"remark-cli": "^6.0.0",
"remark-preset-wooorm": "^4.0.0",
"tape": "^4.4.0",
"typescript": "^3.2.2",
"xo": "^0.23.0"
},
"scripts": {
"format": "remark . -qfo && prettier --write '**/*.js' && xo --fix",
"format": "remark . -qfo && prettier --write '**/{*.js,*.ts}' && xo --fix",
"build-bundle": "browserify index.js -s unified > unified.js",
"build-mangle": "esmangle unified.js > unified.min.js",
"build": "npm run build-bundle && npm run build-mangle",
"test-api": "node test",
"test-coverage": "nyc --reporter lcov tape test",
"test": "npm run format && npm run build && npm run test-coverage"
"test-types": "dtslint types",
"test": "npm run format && npm run build && npm run test-coverage && npm run test-types"
},
"nyc": {
"check-coverage": true,
Expand Down
11 changes: 7 additions & 4 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ no issues found
* [processor.runSync(node\[, file\])](#processorrunsyncnode-file)
* [processor.process(file|value\[, done\])](#processorprocessfilevalue-done)
* [processor.processSync(file|value)](#processorprocesssyncfilevalue)
* [processor.data(key\[, value\])](#processordatakey-value)
* [processor.data(\[key\[, value\]\])](#processordatakey-value)
* [processor.freeze()](#processorfreeze)
* [Plugin](#plugin)
* [function attacher(\[options\])](#function-attacheroptions)
Expand Down Expand Up @@ -739,21 +739,22 @@ Yields:
</html>
```

### `processor.data(key[, value])`
### `processor.data([key[, value]])`

Get or set information in an in-memory key-value store accessible to all phases
of the process. An example is a list of HTML elements which are self-closing,
which is needed when parsing, transforming, and compiling HTML.

###### Parameters

* `key` (`string`) — Identifier
* `key` (`string`, optional) — Identifier
* `value` (`*`, optional) — Value to set. Omit if getting `key`

###### Returns

* `processor` — If setting, the processor on which `data` is invoked
* `*` — If getting, the value at `key`
* `object` - Without arguments, the key-value store

###### Note

Expand All @@ -767,9 +768,11 @@ The following example show how to get and set information:
```js
var unified = require('unified')

unified()
var processor = unified()
.data('alpha', 'bravo')
.data('alpha') // => 'bravo'

processor.data() // {alpha: 'bravo'}
```

### `processor.freeze()`
Expand Down
226 changes: 226 additions & 0 deletions types/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,226 @@
// TypeScript Version: 3.0

import * as Unist from 'unist'
import vfile = require('vfile')

declare namespace unified {
interface Processor {
/**
* @returns New unfrozen processor which is configured to function the same as its ancestor. But when the descendant processor is configured in the future it does not affect the ancestral processor.
*/
(): Processor

/**
* Configure the processor to use a plugin and optionally configure that plugin with options.
*
* @param plugin unified plugin
* @param options Configuration for plugin]
* @returns The processor on which use is invoked
*/
use(plugin: Plugin, options?: unknown): Processor
/**
* @param preset `Object` with an optional plugins (set to list), and/or an optional settings object
*/
use(preset: Preset): Processor
/**
* @param pluginTuple pairs, plugin and options in an array
*/
use(pluginTuple: PluginTuple): Processor
/**
* @param list List of plugins, presets, and pairs
*/
use(list: PluggableList): Processor

/**
* Parse text to a syntax tree.
*
* @param file VFile or anything which can be given to vfile()
* @returns Syntax tree representation of input.
*/
parse(file: VFileCompatible): Unist.Node

/**
* Function handling the parsing of text to a syntax tree.
* Used in the parse phase in the process and invoked with a `string` and `VFile` representation of the document to parse.
*
* `Parser` can be a normal function in which case it must return a `Node`: the syntax tree representation of the given file.
*
* `Parser` can also be a constructor function (a function with keys in its `prototype`) in which case it’s invoked with `new`. Instances must have a parse method which is invoked without arguments and must return a `Node`.
*/
Parser: ParserFunction | typeof Parser

/**
* Compile a syntax tree to text.
*
* @param node
* @param file `VFile` or anything which can be given to `vfile()`
* @returns String representation of the syntax tree file
*/
stringify(node: Unist.Node, file?: VFileCompatible): string

/**
* Function handling the compilation of syntax tree to a text.
* Used in the stringify phase in the process and invoked with a `Node` and `VFile` representation of the document to stringify.
*
* `Compiler` can be a normal function in which case it must return a `string`: the text representation of the given syntax tree.
*
* `Compiler` can also be a constructor function (a function with keys in its `prototype`) in which case it’s invoked with `new`.
* Instances must have a `compile` method which is invoked without arguments and must return a `string`.
*/
Compiler: CompilerFunction | typeof Compiler

/**
* Transform a syntax tree by applying plugins to it.
*
* @param node
* @param file `VFile` or anything which can be given to `vfile()`
* @param done Invoked when transformation is complete.
* Either invoked with an error or a syntax tree and a file.
* @returns `Promise` if `done` is not given. Rejected with an error, or resolved with the resulting syntax tree.
*/
run(node: Unist.Node): Promise<Unist.Node>
run(node: Unist.Node, file: VFileCompatible): Promise<Unist.Node>
run(node: Unist.Node, done: RunCallback): void
run(node: Unist.Node, file: VFileCompatible, done: RunCallback): void

/**
* Transform a syntax tree by applying plugins to it.
*
* If asynchronous plugins are configured an error is thrown.
*
* @param node
* @param file `VFile` or anything which can be given to `vfile()`
* @returns The given syntax tree.
*/
runSync(node: Unist.Node, file?: VFileCompatible): Unist.Node

/**
* Process the given representation of a file as configured on the processor. The process invokes `parse`, `run`, and `stringify` internally.
* @param file
* @param done Invoked when the process is complete. Invoked with a fatal error, if any, and the VFile.
* @returns `Promise` if `done` is not given.
* Rejected with an error or resolved with the resulting file.
*/
process(file: VFileCompatible): Promise<vfile.VFile>
process(file: VFileCompatible, done: ProcessCallback): void

/**
* Process the given representation of a file as configured on the processor. The process invokes `parse`, `run`, and `stringify` internally.
*
* If asynchronous plugins are configured an error is thrown.
*
* @param file
* @returns Virtual file with modified contents.
*/
processSync(file: VFileCompatible): vfile.VFile

/**
* Get or set information in an in-memory key-value store accessible to all phases of the process.
* An example is a list of HTML elements which are self-closing, which is needed when parsing, transforming, and compiling HTML.
*
* @returns key-value store object
*/
data(): {[key: string]: unknown}
/**
* @param key Identifier
* @returns If getting, the value at key
*/
data(key: string): unknown
/**
* @param value Value to set. Omit if getting key
* @returns If setting, the processor on which data is invoked
*/
data(key: string, value: any): Processor

/**
* Freeze a processor. Frozen processors are meant to be extended and not to be configured or processed directly.
*
* Once a processor is frozen it cannot be unfrozen. New processors functioning just like it can be created by invoking the processor.
*
* It’s possible to freeze processors explicitly, by calling `.freeze()`, but `.parse()`, `.run()`, `.stringify()`, and `.process()` call `.freeze()` to freeze a processor too.
*
* @returns The processor on which freeze is invoked.
*/
freeze(): Processor
}

type Plugin = Attacher
type Settings = {
[key: string]: unknown
}
/**
* Presets provide a potentially sharable way to configure processors.
* They can contain multiple plugins and optionally settings as well.
*/
interface Preset {
plugins?: PluggableList
settings?: Settings
}
type PluginTuple = [Plugin, Settings]
type Pluggable = Plugin | Preset | PluginTuple
type PluggableList = Pluggable[]

/**
* An attacher is the thing passed to `use`.
* It configures the processor and in turn can receive options.
*
* Attachers can configure processors, such as by interacting with parsers and compilers, linking them to other processors, or by specifying how the syntax tree is handled.
*
* @this Processor context object is set to the invoked on processor.
* @param options Configuration
* @returns Optional.
*/
interface Attacher {
(this: Processor, options?: unknown): Transformer | void
}

/**
* Transformers modify the syntax tree or metadata of a file. A transformer is a function which is invoked each time a file is passed through the transform phase.
* If an error occurs (either because it’s thrown, returned, rejected, or passed to `next`), the process stops.
*
* The transformation process in unified is handled by `trough`, see it’s documentation for the exact semantics of transformers.
*
* @param node
* @param file
* @param next If the signature of a transformer includes `next` (third argument), the function may finish asynchronous, and must invoke `next()`.
* @returns
* - `Error` — Can be returned to stop the process
* - `Node` — Can be returned and results in further transformations and `stringify`s to be performed on the new tree
* - `Promise` — If a promise is returned, the function is asynchronous, and must be resolved (optionally with a `Node`) or rejected (optionally with an `Error`)
*/
interface Transformer {
(
node: Unist.Node,
file: VFileCompatible,
next?: (error: Error | null, tree: Unist.Node, file: vfile.VFile) => {}
): Error | Unist.Node | Promise<Unist.Node>
}

class Parser {
parse(file: VFileCompatible): Unist.Node
}

type ParserFunction = (file: VFileCompatible) => Unist.Node

class Compiler {
compile(node: Unist.Node, file?: VFileCompatible): string
}
type CompilerFunction = (node: Unist.Node, file?: VFileCompatible) => string

type RunCallback = (
error: Error | null,
node: Unist.Node,
file: vfile.VFile
) => void

type ProcessCallback = (error: Error | null, file: vfile.VFile) => void

type VFileCompatible = vfile.VFile | vfile.VFileOptions | vfile.VFileContents
}

/**
* Object describing how to process text.
*/
declare function unified(): unified.Processor

export = unified
14 changes: 14 additions & 0 deletions types/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"compilerOptions": {
"lib": ["es2015"],
"strict": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"baseUrl": ".",
"paths": {
"unified": ["index.d.ts"]
}
}
}
14 changes: 14 additions & 0 deletions types/tslint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "dtslint/dtslint.json",
"rules": {
"callable-types": false,
"max-line-length": false,
"no-redundant-jsdoc": false,
"no-void-expression": false,
"only-arrow-functions": false,
"semicolon": false,
"unified-signatures": false,
"whitespace": false,
"interface-over-type-literal": false
}
}
Loading

0 comments on commit 7ee2c8f

Please sign in to comment.