Skip to content

Sui followup issue #4642

@aeryz

Description

@aeryz

Followup things to be done after merging #4549:

  • Voyager needs to check whether a token exists with the given salt before deploying it. If it exists, it should use that type name.
  • ZKGM must check the decimals of the previously registered token on recv and also should change the name, symbol and the description accordingly.
  • ZKGM must save the token's typename under a certain quote token so that we don't have multiple tokens for the same quote token.
  • Add PacketByHash impl.
  • Add IbcInterface::IBC_MOVE_SUI
  • Make client_info queryable in the voyager sui state module (for state lens stuff)
  • Read the objects directly instead of dry running
  • Impl fetch blocks s.t. it can catch up. We probably don't want to read all blocks but instead, use a subscription mechanism.
  • Gas simulation or configurable gas.
  • Hussein's comment We miss a verification on scalarApi.AssertIsEqual(&c.InnerWitness.Public[1], commitmentHash) And an extra assertion eq(len(innerwitness.public), 2).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions