fix typechecking for tests

bmesuere · bmesuere · commit 00aa744fec24 · 2026-01-10T14:40:02.000+01:00
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
     "uniprot": "./dist/bin/uniprot.js"
   },
   "scripts": {
-    "build": "yarn run tsc",
+    "build": "yarn run tsc -p tsconfig.build.json",
     "lint": "yarn run eslint",
     "test": "vitest run",
     "test:record": "POLLY_MODE=record vitest run",
diff --git a/tests/commands/peptfilter.test.ts b/tests/commands/peptfilter.test.ts
@@ -1,4 +1,4 @@
-import { Peptfilter } from '../../lib/commands/peptfilter';
+import { Peptfilter } from '../../lib/commands/peptfilter.js';
 import { vi } from 'vitest';
 import * as mock from 'mock-stdin';
 
diff --git a/tests/commands/prot2pept.test.ts b/tests/commands/prot2pept.test.ts
@@ -1,4 +1,4 @@
-import { Prot2pept } from '../../lib/commands/prot2pept';
+import { Prot2pept } from '../../lib/commands/prot2pept.js';
 import { vi } from 'vitest';
 import * as mock from 'mock-stdin';
 
diff --git a/tests/commands/unipept.test.ts b/tests/commands/unipept.test.ts
@@ -1,4 +1,4 @@
-import { Unipept } from '../../lib/commands/unipept';
+import { Unipept } from '../../lib/commands/unipept.js';
 
 test('test if all commands are available', async () => {
   const command = new Unipept();
diff --git a/tests/commands/unipept/pept2ec.test.ts b/tests/commands/unipept/pept2ec.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2ec } from "../../../lib/commands/unipept/pept2ec";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2ec } from "../../../lib/commands/unipept/pept2ec.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2funct.test.ts b/tests/commands/unipept/pept2funct.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2funct } from "../../../lib/commands/unipept/pept2funct";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2funct } from "../../../lib/commands/unipept/pept2funct.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2go.test.ts b/tests/commands/unipept/pept2go.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2go } from "../../../lib/commands/unipept/pept2go";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2go } from "../../../lib/commands/unipept/pept2go.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2interpro.test.ts b/tests/commands/unipept/pept2interpro.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2interpro } from "../../../lib/commands/unipept/pept2interpro";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2interpro } from "../../../lib/commands/unipept/pept2interpro.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2lca.test.ts b/tests/commands/unipept/pept2lca.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2lca } from "../../../lib/commands/unipept/pept2lca";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2lca } from "../../../lib/commands/unipept/pept2lca.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2prot.test.ts b/tests/commands/unipept/pept2prot.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2prot } from "../../../lib/commands/unipept/pept2prot";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2prot } from "../../../lib/commands/unipept/pept2prot.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/pept2taxa.test.ts b/tests/commands/unipept/pept2taxa.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Pept2taxa } from "../../../lib/commands/unipept/pept2taxa";
-import { setupPolly } from '../../mocks/polly';
+import { Pept2taxa } from "../../../lib/commands/unipept/pept2taxa.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/peptinfo.test.ts b/tests/commands/unipept/peptinfo.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Peptinfo } from "../../../lib/commands/unipept/peptinfo";
-import { setupPolly } from '../../mocks/polly';
+import { Peptinfo } from "../../../lib/commands/unipept/peptinfo.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/protinfo.test.ts b/tests/commands/unipept/protinfo.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Protinfo } from "../../../lib/commands/unipept/protinfo";
-import { setupPolly } from '../../mocks/polly';
+import { Protinfo } from "../../../lib/commands/unipept/protinfo.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/retry_logic.test.ts b/tests/commands/unipept/retry_logic.test.ts
@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { UnipeptSubcommand } from '../../../lib/commands/unipept/unipept_subcommand';
+import { UnipeptSubcommand } from '../../../lib/commands/unipept/unipept_subcommand.js';
 
 // Concrete implementation for testing abstract class
 class TestSubcommand extends UnipeptSubcommand {
diff --git a/tests/commands/unipept/taxa2lca.test.ts b/tests/commands/unipept/taxa2lca.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Taxa2lca } from "../../../lib/commands/unipept/taxa2lca";
-import { setupPolly } from '../../mocks/polly';
+import { Taxa2lca } from "../../../lib/commands/unipept/taxa2lca.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/taxonomy.test.ts b/tests/commands/unipept/taxonomy.test.ts
@@ -1,6 +1,6 @@
 import { vi, afterAll } from 'vitest';
-import { Taxonomy } from "../../../lib/commands/unipept/taxonomy";
-import { setupPolly } from '../../mocks/polly';
+import { Taxonomy } from "../../../lib/commands/unipept/taxonomy.js";
+import { setupPolly } from '../../mocks/polly.js';
 import { Polly } from '@pollyjs/core';
 
 let output: string[];
diff --git a/tests/commands/unipept/unipept_subcommand.test.ts b/tests/commands/unipept/unipept_subcommand.test.ts
@@ -1,4 +1,4 @@
-import { Pept2lca } from '../../../lib/commands/unipept/pept2lca';
+import { Pept2lca } from '../../../lib/commands/unipept/pept2lca.js';
 
 test('test command setup', () => {
   const command = new Pept2lca();
diff --git a/tests/commands/uniprot.test.ts b/tests/commands/uniprot.test.ts
@@ -1,4 +1,4 @@
-import { Uniprot } from '../../lib/commands/uniprot';
+import { Uniprot } from '../../lib/commands/uniprot.js';
 import { vi } from 'vitest';
 import * as mock from 'mock-stdin';
 
diff --git a/tests/formatters/csv_formatter.test.ts b/tests/formatters/csv_formatter.test.ts
@@ -1,5 +1,5 @@
-import { FormatterFactory } from "../../lib/formatters/formatter_factory";
-import { TestObject } from "./test_object";
+import { FormatterFactory } from "../../lib/formatters/formatter_factory.js";
+import { TestObject } from "./test_object.js";
 
 const formatter = FormatterFactory.getFormatter("csv");
 
diff --git a/tests/formatters/formatter.test.ts b/tests/formatters/formatter.test.ts
@@ -1,5 +1,5 @@
-import { FormatterFactory } from "../../lib/formatters/formatter_factory";
-import { TestObject } from "./test_object";
+import { FormatterFactory } from "../../lib/formatters/formatter_factory.js";
+import { TestObject } from "./test_object.js";
 
 test('test integrate fasta headers', async () => {
   const formatter = FormatterFactory.getFormatter("csv");
diff --git a/tests/formatters/formatter_factory.test.ts b/tests/formatters/formatter_factory.test.ts
@@ -1,4 +1,4 @@
-import { FormatterFactory } from "../../lib/formatters/formatter_factory";
+import { FormatterFactory } from "../../lib/formatters/formatter_factory.js";
 
 test('test if default formatter is csv', async () => {
   const formatter = FormatterFactory.getFormatter("foo");
diff --git a/tests/formatters/json_formatter.test.ts b/tests/formatters/json_formatter.test.ts
@@ -1,5 +1,5 @@
-import { FormatterFactory } from "../../lib/formatters/formatter_factory";
-import { TestObject } from "./test_object";
+import { FormatterFactory } from "../../lib/formatters/formatter_factory.js";
+import { TestObject } from "./test_object.js";
 
 const formatter = FormatterFactory.getFormatter("json");
 
diff --git a/tests/formatters/xml_formatter.test.ts b/tests/formatters/xml_formatter.test.ts
@@ -1,5 +1,5 @@
-import { FormatterFactory } from "../../lib/formatters/formatter_factory";
-import { TestObject } from "./test_object";
+import { FormatterFactory } from "../../lib/formatters/formatter_factory.js";
+import { TestObject } from "./test_object.js";
 
 const formatter = FormatterFactory.getFormatter("xml");
 
diff --git a/tests/mocks/polly.ts b/tests/mocks/polly.ts
@@ -4,14 +4,16 @@ import NodeHttpAdapter from '@pollyjs/adapter-fetch';
 import FSPersister from '@pollyjs/persister-fs';
 import { fileURLToPath } from 'url';
 
+// @ts-ignore
 Polly.register(NodeHttpAdapter);
+// @ts-ignore
 Polly.register(FSPersister);
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
 export function setupPolly(recordingName: string) {
-  const mode = process.env.POLLY_MODE || 'replay';
+  const mode: 'record' | 'replay' | 'passthrough' = process.env.POLLY_MODE as 'record' | 'replay' | 'passthrough' || 'replay';
 
   return new Polly(recordingName, {
     adapters: ['fetch'],
@@ -23,7 +25,7 @@ export function setupPolly(recordingName: string) {
     },
     // Default to replay, but record if missing.
     // This allows CI to just replay, but local devs can generate missing recordings.
-    mode: mode as any,
+    mode: mode,
     recordIfMissing: true,
     flushRequestsOnStop: true,
   });
diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -0,0 +1,13 @@
+{
+  "include": [
+    "bin/**/*",
+    "lib/**/*",
+  ],
+  "compilerOptions": {
+    "outDir": "./dist",
+    "module": "NodeNext",
+    "strict": true,
+    "resolveJsonModule": true,
+    "target": "esnext"
+  }
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,14 +1,12 @@
 {
+  "extends": "./tsconfig.build.json",
   "include": [
     "bin/**/*",
     "lib/**/*",
+    "tests/**/*"
   ],
   "compilerOptions": {
-    "outDir": "./dist",
-    "module": "NodeNext",
-    "strict": true,
-    "resolveJsonModule": true,
-    "target": "esnext",
+    "noEmit": true,
     "types": [
       "vitest/globals"
     ]

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Peptfilter } from '../../lib/commands/peptfilter';`
	`1`	`+import { Peptfilter } from '../../lib/commands/peptfilter.js';`
`2`	`2`	`import { vi } from 'vitest';`
`3`	`3`	`import * as mock from 'mock-stdin';`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Prot2pept } from '../../lib/commands/prot2pept';`
	`1`	`+import { Prot2pept } from '../../lib/commands/prot2pept.js';`
`2`	`2`	`import { vi } from 'vitest';`
`3`	`3`	`import * as mock from 'mock-stdin';`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Unipept } from '../../lib/commands/unipept';`
	`1`	`+import { Unipept } from '../../lib/commands/unipept.js';`
`2`	`2`
`3`	`3`	`test('test if all commands are available', async () => {`
`4`	`4`	`const command = new Unipept();`