Merge branch 'fix/update-dependencies' into feature/barplot

Author: pverscha

.github/workflows/test.yml

@@ -24,3 +24,16 @@ jobs:
         run: npm i -g jest-cli
       - name: Run tests
         run: npm run test
+      - name: Sanitize filenames
+        if: failure()
+        run: |
+          find test/snapshots -depth -name '*[<>:"|?*]*' | while read file; do
+            safe_name=$(echo "$file" | sed 's/[<>:"|?*]/_/g')
+            mv "$file" "$safe_name"
+          done
+      - name: Upload failed images
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+         name: regression-images
+         path: test/snapshots

.gitignore

@@ -1,2 +1,3 @@
 node_modules/*
 .DS_Store
+test/snapshots/diffs

package-lock.json

@@ -32,9 +32,9 @@
         "d3": "^7.9.0"
     },
     "devDependencies": {
+        "@eslint/js": "^9.0.0",
         "@types/d3": "^7.4.3",
         "@types/jsdom": "^16.2.7",
-        "@eslint/js": "^9.0.0",
         "@typescript-eslint/eslint-plugin": "^8.29.0",
         "@typescript-eslint/parser": "^8.29.0",
         "@vitest/ui": "^3.1.2",
@@ -44,6 +44,8 @@
         "eslint-define-config": "^2.1.0",
         "flush-promises": "^1.0.2",
         "jsdom": "^26.1.0",
+        "pixelmatch": "^7.1.0",
+        "pngjs": "^7.0.0",
         "puppeteer": "^24.7.2",
         "regenerator-runtime": "^0.13.7",
         "typescript": "^4.1.2",

package.json

@@ -13,7 +13,7 @@ export default class TestConsts {
 
         return {
             comparisonMethod: "ssim",
-            failureThreshold: 0.02,
+            failureThreshold: 0.1,
             failureThresholdType: "percent",
             customSnapshotsDir: path.replace("src", "test/snapshots"),
             customDiffDir: path.replace("src", "test/snapshots/diffs")

src/test/TestConsts.ts

@@ -1,14 +1,14 @@
 
-import { waitForCondition } from "./../../../test/TestUtils";
+import { waitForCondition } from "../../../test/TestUtils";
 import TestConsts from "./../../../test/TestConsts";
 import TreemapSettings from "./../TreemapSettings";
 import { JSDOM } from "jsdom";
 import Treemap from "./../Treemap";
 import DataNode from "./../../../DataNode";
 import { describe, it, expect, beforeAll, afterAll } from "vitest";
 
-const puppeteer = require("puppeteer");
-const taxonomyObject = require("./resources/taxonomy.json");
+import puppeteer from "puppeteer";
+import taxonomyObject from "./resources/taxonomy.json";
 
 describe("Treemap", () => {
     let browser: any;
@@ -56,7 +56,7 @@ describe("Treemap", () => {
 
     it("should render a treemap with default settings", async() => {
         const jsDom = createJSDom();
-        const treemap = await createTreemap(jsDom, {});
+        const treemap = await createTreemap(jsDom, new TreemapSettings());
 
         const image = await makeScreenshot(jsDom);
         expect(image).toMatchImageSnapshot(TestConsts.resolveImageSnapshotFolder(__filename));
@@ -67,23 +67,24 @@ describe("Treemap", () => {
 
         let nodeFromCallback: DataNode | null = null;
 
-        const treemap = await createTreemap(jsDom, {
-            rerootCallback: (d: DataNode) => nodeFromCallback = d
-        });
+        const settings = new TreemapSettings();
+        settings.rerootCallback = (d: DataNode) => nodeFromCallback = d;
+
+        const treemap = await createTreemap(jsDom, settings);
 
-        expect(nodeFromCallback.name).toEqual("root");
+        expect(nodeFromCallback!.name).toEqual("root");
 
         // new Event("click") does apparently not work in combination with Jest and JSDOM
         const event = jsDom.window.document.createEvent("CustomEvent");
         event.initEvent("click", true, true);
 
         const oldSerializedHtml = jsDom.serialize();
 
-        jsDom.window.document.getElementsByClassName("node").item(1).dispatchEvent(event);
+        jsDom.window.document.getElementsByClassName("node").item(1)!.dispatchEvent(event);
 
         await waitForCondition(() => oldSerializedHtml !== jsDom.serialize(), 2000, 500);
 
-        expect(nodeFromCallback.name).toEqual("Bacteria");
+        expect(nodeFromCallback!.name).toEqual("Bacteria");
     });
 
     afterAll(async() => {