Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][0.3.9] Authentication method concern due to deprecation of token in API’s query string for Memsource TMS APIs #27

Open
cyril-ui-developer opened this issue Oct 18, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@cyril-ui-developer
Copy link

Describe the bug
Find out the impact of the deprecation and how to change the authentication method to one of the supported ones.

Affected version

To Reproduce
Steps to reproduce the behavior

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots or Traceback
If applicable, add screenshots or Traceback to help explain your problem.

Additional context
Add any other context about the problem here.

@cyril-ui-developer cyril-ui-developer added the bug Something isn't working label Oct 18, 2022
@zerodayz
Copy link
Member

zerodayz commented Oct 26, 2022

Hi @cyril-ui-developer

It needs to be changed https://github.com/unofficial-memsource/memsource-cli-client/blob/master/memsource_cli/api_client.py#L103

Add something like:

if query_params['token']:
    header_params.append('Authorization', "Bearer " + query_params['token'])
    query_params.remove('token') 

Would you like to take this? or maybe @ludekjanda can change it.

@cyril-ui-developer
Copy link
Author

Hi @cyril-ui-developer

It needs to be changed https://github.com/unofficial-memsource/memsource-cli-client/blob/master/memsource_cli/api_client.py#L103

Add something like:

if query_params['token']:
    header_params.append('Authorization', "Bearer " + query_params['token'])
    query_params.remove('token') 

Would you like to take this? or maybe @ludekjanda can change it.

@zerodayz Feel free to take it or assign it to @ludekjanda. I am not familiar with the codebase. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants