test: update sample tests for webview #20798
Conversation
github-actions
bot
added
the
area/automation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sample tests for WebView controls by enhancing existing functionality and adding new samples to test fixed height and clipping behaviors.
- Updated the WebView_Title sample with a new URL navigation handler and adjusted the TextBox width.
- Added two new samples: one to demonstrate a fixed-height WebView2 and another to test clipping with WebView2.
- Updated project items to include the new sample files.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView_Title.xaml.cs | Added OnGoClicked method to handle URL navigation. |
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView_Title.xaml | Increased TextBox width and hooked up the Button Click event. |
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView2_Fixed_Height.xaml.cs | New sample demonstrating a fixed-height WebView2. |
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView2_Fixed_Height.xaml | New sample UI for WebView2 with fixed height. |
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView2_Clipping.xaml.cs | New sample demonstrating clipping with WebView2. |
| src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView2_Clipping.xaml | New sample UI for WebView2 clipping tests. |
| src/SamplesApp/UITests.Shared/UITests.Shared.projitems | Updated to include the new WebView sample pages. |
Comments suppressed due to low confidence (1)
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView_Title.xaml.cs:24
- In a UI event handler for a test sample, throwing an exception on invalid input may interrupt the test flow unexpectedly. Consider handling invalid URLs gracefully, such as by providing user feedback without an exception.
throw new ArgumentException("The provided URL is not valid.", nameof(UriInput));
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
|
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/WebView/WebView_Title.xaml.cs
Outdated
Show resolved
Hide resolved
ajpinedam
force-pushed
the
fix/wasm.skia.webview.clip
branch
from
1f3271d to
82fd703
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
1 similar comment
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
ajpinedam
force-pushed
the
fix/wasm.skia.webview.clip
branch
from
86e505d to
5abfe4b
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
|
|
ajpinedam
force-pushed
the
fix/wasm.skia.webview.clip
branch
from
5abfe4b to
6953106
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20798/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20798/docs/index.html |
3 participants
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️