feat: Update RatingControl to winui3/release/1.7.3
#21181
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RatingControl implementation to align with WinUI 3 release version 1.7.3, modernizing the control's sizing and layout behavior.
Key changes:
- Replaced hardcoded values with resource-based configuration for font size, item spacing, and caption margins
- Improved sizing calculations to support dynamic text scaling and better layout positioning
- Added new test coverage for verifying resource-based size changes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RatingControl.mux.cs | Core implementation updated with resource-based sizing, improved layout calculations, and removed text scale factor handling |
| RatingControl.h.mux.cs | Added new private fields for resource management and transform handling |
| RatingControlTests.cs | New test method to verify dynamic sizing behavior through resource changes |
| themeresources_v2.xaml | Updated control template with new styling approach and resource references |
| RatingControl_themeresources.xaml | Added resource definitions for font size, item spacing, and caption margins |
| RatingControl.xaml | Template changes matching the main theme resources file |
src/Uno.UI/Microsoft/UI/Xaml/Controls/RatingControl/RatingControl.mux.cs
Outdated
Show resolved
Hide resolved
|
|
||
| m_mousePercentage = (double)(xPosition) / CalculateActualRatingWidth(); | ||
| m_mousePercentage = (xPosition - m_firstItemOffset) / CalculateActualRatingWidth(); | ||
|
|
||
| UpdateRatingItemsAppearance(); | ||
| args.Handled = true; | ||
| UpdateRatingItemsAppearance(); |
There was a problem hiding this comment.
Potential division by zero if CalculateActualRatingWidth() returns 0. This could occur when MaxRating is 0 or ActualRatingFontSize() returns 0. Consider adding a check to prevent division by zero.
Copilot uses AI. Check for mistakes.
src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/RatingControl/RatingControlTests.cs
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/RatingControl/RatingControlTests.cs
Show resolved
Hide resolved
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21181/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21181/docs/index.html |
|
|
MartinZikmund
force-pushed
the
dev/mazi/rating-control-update
branch
from
9e57dc2 to
f3fcc27
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21181/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21181/wasm-skia-net9/index.html |
|
|
MartinZikmund
force-pushed
the
dev/mazi/rating-control-update
branch
from
f3fcc27 to
7081d54
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21181/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21181/docs/index.html |
|
|
GitHub Issue: related to #21148
related to unoplatform/uno.chefs#1668
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️