Skip to content

Commit 13bba40

Browse files
Gidi & PetrutMarmaladeDevelopers
authored andcommitted
Fixed Promise shim usage in VastChainer
1 parent 5142c31 commit 13bba40

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/js/vastChainer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ function domainAllowsCorsCookies(vastConfig, url) {
2222

2323
module.exports = function(
2424
{
25-
promiseModule = promiseShim,
25+
PromiseModule = Promise,
2626
$ = jQuery,
2727
parseVast = vastParser.parse,
2828
Response = VastResponse
29-
}) {
29+
} = {}) {
3030

3131
var vastRequestCounter = 0,
3232
dispatcher = $({});
@@ -40,7 +40,7 @@ module.exports = function(
4040
var url = vastConfig.url,
4141
resolve,
4242
reject,
43-
promise = new promiseModule.Promise(function(_resolve, _reject) {
43+
promise = new PromiseModule(function(_resolve, _reject) {
4444

4545
resolve = _resolve;
4646
reject = _reject;

test/specs/vastChainerSpec.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,9 @@ describe('VAST Chainer', function(){
4040
resolve: sinon.stub()
4141
};
4242

43-
let promiseModule = {
44-
Promise: function(callback) {
45-
callback(mockDeferred.resolve, mockDeferred.reject);
46-
return mockPromise;
47-
}
43+
let PromiseModule = function(callback) {
44+
callback(mockDeferred.resolve, mockDeferred.reject);
45+
return mockPromise;
4846
};
4947

5048
mockDispatcher = {
@@ -98,7 +96,7 @@ describe('VAST Chainer', function(){
9896
};
9997

10098
mockDeps = {
101-
promiseModule,
99+
PromiseModule,
102100
$,
103101
parseVast
104102
};

0 commit comments

Comments
 (0)