[role] Improve syntax and conditions

Author: goldyfruit

defaults/main.yml

@@ -9,7 +9,7 @@ corosync_node_list:
   - ctrl01
   - ctrl02
   - ctrl03
-corosync_transport: 'udpu'
+corosync_transport: udpu
 corosync_interfaces:
   - bindnetaddr: 192.168.56.0
     mcastport: 5405

handlers/main.yml

@@ -1,7 +1,6 @@
 ---
 # file: roles/corosync/handlers/main.yml
-- name: Restart Corosync
+- name: restart corosync
   service:
     name=corosync
     state=restarted
-    enabled=yes

tasks/backport.yml

@@ -6,7 +6,7 @@
     state=present
     update_cache=yes
 
-- name: Install Corosync packages (Debian Jessie only)
+- name: Installing Corosync package (Debian Jessie only)
   apt:
     name=corosync
     state=latest

tasks/configuration.yml

@@ -4,9 +4,9 @@
   template:
     src=etc/corosync/corosync.conf.j2
     dest=/etc/corosync/corosync.conf
-  notify: Restart Corosync
+  notify: restart corosync
 
-- name: Starting Corosync service
+- name: Making sure that Corosync service is started
   service:
     name=corosync
     state=started

tasks/firewall.yml

@@ -6,5 +6,4 @@
     permanent=true
     state=enabled
     immediate=true
-  with_items:
-    - "{{ corosync_interfaces }}"
+  with_items: "{{ corosync_interfaces }}"

tasks/install.yml

@@ -1,12 +1,14 @@
 ---
 # file: roles/corosync/tasks/install.yml
-- name: Install Corosync packages
+- name: Installing Corosync package
   package:
     name=corosync
     state=latest
-  when: ansible_distribution_release != 'jessie'
+  when: ansible_distribution_release != 'jessie' and
+        corosync_debian_backports is defined and
+        corosync_debian_backports
 
-- name: Enable Corosync service
+- name: Enabling Corosync service
   service:
     name=corosync
     enabled=yes

tasks/main.yml

@@ -15,6 +15,7 @@
         corosync_haveged
 
 - include: firewall.yml
+  tags: [ corosync, corosync-firewall ]
   when: corosync_firewalld is defined and
         corosync_firewalld
 

vars/main.yml

@@ -2,3 +2,4 @@
 # file: roles/corosync/vars/main.yml
 corosync_apt_backports: "deb http://ftp.debian.org/debian jessie-backports main"
 corosync_default_release: jessie-backports
+corosync_tmp_authkey: /tmp/authkey