-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Frontend #930
Comments
I have an idea that might help tremendously. I could attempt to implement a scrolling "back to top" button that would allow users who have scrolled way down the page to get back up to the search bar without needing to scroll all the way back manually. Other suggestions may come to me as I use the site. |
@NjalTheKnut That will be a good feature, go for it. |
hi,can i undertake the work proposed by NjalTheKnut... |
I actually found out how to do it recently. I am willing to do it and have a second person go over the code to ensure I am doing things in the best fashion possible. Being somewhat inexperienced with remote team mechanics, I would appreciate a little guidance acquiring the code and making certain I don't foul up production branches in the VCS. Also, am I allowed to introduce jQuery, if it is not already used in this project? |
up-for-grabs.net-gh-pages 2.zipi have completed the task... |
@sunilkumarvalmiki Can you host this on your fork? it will be easy to review that way. |
yes, i forked it to my profile. |
@NjalTheKnut I meant if you can host this as github pages on your fork so that we can see it live. |
@ritwik12 Hey there! I actually wanted to make some changes to the front-end, but I noticed the _site folder holding the index.html and stylesheets is in git.ignore. Just wanted to know if I can "un-ignore" the file or if not, how I can proceed. |
Those files are not supposed to be committed, as they are regenerated by Jekyll - the engine underneath GitHub Pages. If you want to test things out on your fork, this guide should help ensure it is configured right. Alternatively, you can try and get Jekyll running locally or use the included |
@shiftkey Hey thanks for responding. I had the environment running locally already, I was just testing the index and stylesheet from the _site folder and so naturally my changes weren't showing when I ran |
@Supreme-Kai the assignee field is based on organization membership, but feel free to work on this and propose changes in a PR |
Oh right, got it. Awesome, I'll do that. Thanks. |
This comment has been minimized.
This comment has been minimized.
These two white spaces at the sides always trouble me :P How about if we just increase the Centre block on both sides so that The projects with Long description will at least get in few lines than so many lines as shown in this image. Also, we can improve the button on the bottom right corner to a good design. For now, it is simply a bold look. |
@ritwik12 I have some ideas for improving FE of the project and enhance user-experience:
I can write this in TypeScript using react / next.js, if you will allow. (I know that using a framework for such a simple project can be overkill but maybe he will grow into something more?) |
@ritwik12 ok, I will make PSD layout. |
@ritwik12 okay... something like this. Of course, design is not final and i'm open for your suggestions. Also, current logo is not suitable for the dark theme, if you have .eps / .ai or .svg of it, i can fix this. |
@rustmn That's good. From my point of view I would love to have the old look and improve that. The current look is awesome and lets improve that. For Dark mode. It will be good if we have a toggle or button to switch between Dark and Light modes of the site. Will prefer the Light mode for default though. I really like the left part, Your views @shiftkey for left side area. |
@rustmn If it's not a long work, can you try and add the left part to the present website and share how it looks. Check the tone of color for whichever looks better there. I guess black would suite too |
@ritwik12 ok, done. It might look something like this: The search does not work correctly yet, because I have not figured out how it works. Also, when I open your site, my screen locks for 2 seconds, due to the fact that all projects are rendered at the same time. I can fix this. If this is done for web scrapers, I can make api for this. |
@rustmn Not able to see the view :( |
@ritwik12 hm... strange. Then so: https://rustmn.github.io |
Try to read https://www.atlassian.com/git/tutorials/using-branches/merge-conflicts. For simple steps, github opens a merge conflict window when there are merge conflicts. just go there and remove those lines with <<<<< and ===== which are not related to your code. |
Yeah, actually I anticipated that checks are failing due to merge conflicts but they can only be resolved if I get yours or any authorities to take a look at it and let me know that changes I have made are acceptable or not , because for eg , I changed the table tags to div tags for better front end design because there is not so much you can do while using table tags , the changes are very small in terms of number of lines changed , I think changing the table tag into the div is the only major change which requires you/authorities to take a look otherwise there are some minor changes like some lines in CSS file and so on . In all let me know what you think , and what do you think of the new design , I was thinking that after it gets merged , we can do some more changes after that , but majorly the design will look something like this( depicted in screenshots ) |
Hi, that's a really good design , i think it is better than the current, also I guess we can make the side menu bar collapse into a little burger option on top which will be set to sticky so that user can use filters whenever they want after scrolling , all good but I guess we gotta keep the logo out of menu bar , if it collapses with the rest of the menu into a button it won't be visible at the website anymore or is it fine ? |
That's a good design @AllanOcelot. Thanks for the ideas. @Jai2305 You are right, it would be great to have it as a collapsible side bar. For the logo I would say let's try to keep it on top left for this where after collapsible it'll stay there in form of a semi circle or circle. Thoughts? |
Yeah, I guess we can do that , I am just trying to figure out the mobile version of this in which rather then left logo stays on top. |
Glad you like it - happy to tweak things, if there's interest in getting this going forward I can certainly Mock up a mobile version with a collapsible sidebar & smaller logo/icons etc. Realistically it would be Tuesday/Wednesday night due to work commitments - but I'm following the thread and will work other suggestions etc in |
Yeah @AllanOcelot, that would be awesome. If you are busy and @Jai2305 is ready to work on it. It would be great to have the mobile design too. |
I'm also interested in implementing mobile layout when the design is ready 👍 |
Another source of ideas for improvement could potentially come from looking at the Lighthouse report for up for grabs.net. I suppose these might be considered to be optimizations rather than improvements but thought of sharing anyway. Here's a sample report run from my browser with mobile as the targeted platform: |
@jalaniz1 Thanks for sharing the report. I think we can work on this and open up few issues to take the concerns. |
I've been going through this thread and while I do not wish to greatly alter the layout of the site (it seems alternate layouts have been proposed by others), there are few changes that I made for the color theme and I'd like to suggest them. Light Mode:
Dark Mode:
Please let me know about these changes and I'd appreciate further suggestions from your end. |
@JeetPatel1016 Thanks for your suggestions. All your suggestions look good to me, especially the Dark Mode contrast. Please go ahead with your changes except for the logo change. The current logo in bright mode looks better than your suggestion here. |
@ritwik12 I've raised a PR and dropped the logo change as you mentioned. |
Not sure if I shoud create a separate issue for this. The first time I opened the https://up-for-grabs.net/ I couldn't understand where should I click to start. It's not intuitive enough that the "I want to get envolved" group is clickable. |
I'd love to take on the dark mode feature. Where can I find the project structure to know where to make changes? |
@ritwik12 Hey I'd love to contribute in frontend mostly in Design and some features as I guess there is lots of room for changes, some design I thought along with the color combi. , let me know if this would work for the issue or not . |
BEFORE ==> mistakes that I found =>
AFTER ==> |
@ritwik12 are there any more issues left for me to undertake as I am interested in improving the FE of site and contributing |
Hello @ritwik12, since its been a long time this issue has opened from, is there any help I can provide on this at present ? I would love to contribute 🙌 |
Hello @ritwik12, I see the UI, since its been a long time this issue has opened I believe up-for-grabs.net could benefit from a few UI improvements to enhance its look and usability.
I would love to contribute, here is my suggestion to add this type of animation These changes would make the site both visually pleasing and more user-friendly |
I want to add these type of changes, please assign to me! |
The dark mode as it is currently on the site looks great, but I noticed that:
|
At present, up-for-grabs.net is great content wise and is also good in front-end, But I can see a lot of potential for improvement as there are so many great web designers who can make up-for-grabs.net a very beautiful website. I would recommend awwwards for getting ideas.
Few points to work on as per @camilosampedro suggestions in the comments:
The text was updated successfully, but these errors were encountered: