Skip to content

Commit 7e0f697

Browse files
authored
Merge pull request #529 from urbanairship/GH-528
Fix old architecture channelEditTags method
2 parents cd6f0d1 + 97b5471 commit 7e0f697

File tree

8 files changed

+39
-25
lines changed

8 files changed

+39
-25
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# React Native Module Changelog
22

3+
## Version 16.1.1 - September 22, 2023
4+
Patch release that updates the iOS SDK to 17.3.1 and fixes Channel Tag Editor for React Native old architecture.
5+
6+
### Changes
7+
- Updated iOS SDK to 17.3.1
8+
- Fixed `Airship.channel.editTags()` for React Native old architecture
9+
310
## Version 16.1.0 - September 11, 2023
411
Minor release that updates the iOS SDK to 17.3.0 and Android SDK to 17.2.1. Also adds support for Airship Feature Flag feature and for Channel Tag Editor.
512

android/gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Airship_targetSdkVersion=31
44
Airship_compileSdkVersion=31
55
Airship_ndkversion=21.4.7075529
66

7-
Airship_airshipProxyVersion=4.2.0
7+
Airship_airshipProxyVersion=4.3.0
88

99
# workaround for now, used for HMS
1010
Airship_airshipVersion=17.2.1

android/src/main/java/com/urbanairship/reactnative/AirshipModule.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
161161
}
162162

163163
@ReactMethod
164-
override fun channelEditTags(operations: ReadableArray, promise: Promise) {
164+
override fun channelEditTags(operations: ReadableArray?, promise: Promise) {
165165
promise.resolveResult {
166166
proxy.channel.editTags(Utils.convertArray(operations).toJsonValue())
167167
}

android/src/oldarch/java/com/urbanairship/reactnative/AirshipSpec.kt

+7
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@ abstract class AirshipSpec internal constructor(context: ReactApplicationContext
6060
promise: Promise
6161
)
6262

63+
@ReactMethod
64+
@com.facebook.proguard.annotations.DoNotStrip
65+
abstract fun channelEditTags(
66+
operations: ReadableArray?,
67+
promise: Promise
68+
)
69+
6370
@ReactMethod
6471
@com.facebook.proguard.annotations.DoNotStrip
6572
abstract fun channelEditAttributes(

example/ios/Podfile.lock

+20-20
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
PODS:
2-
- Airship (17.3.0):
3-
- Airship/Automation (= 17.3.0)
4-
- Airship/Basement (= 17.3.0)
5-
- Airship/Core (= 17.3.0)
6-
- Airship/FeatureFlags (= 17.3.0)
7-
- Airship/MessageCenter (= 17.3.0)
8-
- Airship/PreferenceCenter (= 17.3.0)
9-
- Airship/Automation (17.3.0):
2+
- Airship (17.3.1):
3+
- Airship/Automation (= 17.3.1)
4+
- Airship/Basement (= 17.3.1)
5+
- Airship/Core (= 17.3.1)
6+
- Airship/FeatureFlags (= 17.3.1)
7+
- Airship/MessageCenter (= 17.3.1)
8+
- Airship/PreferenceCenter (= 17.3.1)
9+
- Airship/Automation (17.3.1):
1010
- Airship/Core
11-
- Airship/Basement (17.3.0)
12-
- Airship/Core (17.3.0):
11+
- Airship/Basement (17.3.1)
12+
- Airship/Core (17.3.1):
1313
- Airship/Basement
14-
- Airship/FeatureFlags (17.3.0):
14+
- Airship/FeatureFlags (17.3.1):
1515
- Airship/Core
16-
- Airship/MessageCenter (17.3.0):
16+
- Airship/MessageCenter (17.3.1):
1717
- Airship/Core
18-
- Airship/PreferenceCenter (17.3.0):
18+
- Airship/PreferenceCenter (17.3.1):
1919
- Airship/Core
20-
- AirshipFrameworkProxy (4.2.0):
21-
- Airship (= 17.3.0)
20+
- AirshipFrameworkProxy (4.3.0):
21+
- Airship (= 17.3.1)
2222
- boost (1.76.0)
2323
- CocoaAsyncSocket (7.6.5)
2424
- DoubleConversion (1.1.6)
@@ -317,8 +317,8 @@ PODS:
317317
- React-jsinspector (0.71.1)
318318
- React-logger (0.71.1):
319319
- glog
320-
- react-native-airship (16.1.0):
321-
- AirshipFrameworkProxy (= 4.2.0)
320+
- react-native-airship (16.1.1):
321+
- AirshipFrameworkProxy (= 4.3.0)
322322
- React-Core
323323
- react-native-safe-area-context (4.5.0):
324324
- RCT-Folly
@@ -581,8 +581,8 @@ EXTERNAL SOURCES:
581581
:path: "../node_modules/react-native/ReactCommon/yoga"
582582

583583
SPEC CHECKSUMS:
584-
Airship: 73ee3648eb6864be959246427e084b60536ae0dc
585-
AirshipFrameworkProxy: a6e3e4357e6d65dd33c5bec39219a859762709c1
584+
Airship: a8ec7140cca677696f10f605749c18248d818117
585+
AirshipFrameworkProxy: 581e2ca4c3b2377724d0235117d617df8489097a
586586
boost: 57d2868c099736d80fcd648bf211b4431e51a558
587587
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
588588
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
@@ -616,7 +616,7 @@ SPEC CHECKSUMS:
616616
React-jsiexecutor: 60cf272aababc5212410e4249d17cea14fc36caa
617617
React-jsinspector: ff56004b0c974b688a6548c156d5830ad751ae07
618618
React-logger: 60a0b5f8bed667ecf9e24fecca1f30d125de6d75
619-
react-native-airship: a254a0fb81c4ebe6dccc95c7644b5b84c90adc65
619+
react-native-airship: a7222b49a0cfa0bdd9dc3981c15f808a9ae90740
620620
react-native-safe-area-context: 39c2d8be3328df5d437ac1700f4f3a4f75716acc
621621
React-perflogger: ec8eef2a8f03ecfa6361c2c5fb9197ef4a29cc85
622622
React-RCTActionSheet: a0c023b86cf4c862fa9c4eb0f6f91fbe878fb2de

ios/AirshipReactNative.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class AirshipReactNative: NSObject {
3636
AirshipProxy.shared
3737
}
3838

39-
public static let version: String = "16.1.0"
39+
public static let version: String = "16.1.1"
4040

4141
private let eventNotifier = EventNotifier()
4242

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ua/react-native-airship",
3-
"version": "16.1.0",
3+
"version": "16.1.1",
44
"description": "Airship plugin for React Native apps.",
55
"main": "lib/commonjs/index",
66
"module": "lib/module/index",

react-native-airship.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ Pod::Spec.new do |s|
3636

3737

3838

39-
s.dependency "AirshipFrameworkProxy", "4.2.0"
39+
s.dependency "AirshipFrameworkProxy", "4.3.0"
4040

4141
end

0 commit comments

Comments
 (0)