Skip to content

Commit 9f62c98

Browse files
authored
Merge pull request #389 from urbanairship/GHI-382
[GHI-382] Fix iOS behavior with auto launch message center
2 parents 21174dc + fa6c61e commit 9f62c98

File tree

5 files changed

+7
-73
lines changed

5 files changed

+7
-73
lines changed

urbanairship-react-native/ios/UARCTModule.xcodeproj/project.pbxproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
6ED67C292318812700169F5C /* UARCTMessageView.m in Sources */ = {isa = PBXBuildFile; fileRef = 6ED67C252318812700169F5C /* UARCTMessageView.m */; };
1515
6ED67C2A2318812700169F5C /* UARCTMessageViewManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 6ED67C282318812700169F5C /* UARCTMessageViewManager.m */; };
1616
6ED701FA1F6C91A400E67C37 /* UARCTDeepLinkAction.m in Sources */ = {isa = PBXBuildFile; fileRef = 6ED701F91F6C91A400E67C37 /* UARCTDeepLinkAction.m */; };
17-
F8A9D23B1F3CF8870087D225 /* UARCTMessageViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = F8A9D23A1F3CF8870087D225 /* UARCTMessageViewController.m */; };
1817
F8AA2B681EEF04C0008653D8 /* UARCTMessageCenter.m in Sources */ = {isa = PBXBuildFile; fileRef = F8AA2B671EEF04C0008653D8 /* UARCTMessageCenter.m */; };
1918
/* End PBXBuildFile section */
2019

@@ -46,8 +45,6 @@
4645
6ED67C282318812700169F5C /* UARCTMessageViewManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = UARCTMessageViewManager.m; path = UARCTModule/UARCTMessageViewManager.m; sourceTree = "<group>"; };
4746
6ED701F81F6C91A400E67C37 /* UARCTDeepLinkAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UARCTDeepLinkAction.h; path = UARCTModule/UARCTDeepLinkAction.h; sourceTree = "<group>"; };
4847
6ED701F91F6C91A400E67C37 /* UARCTDeepLinkAction.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = UARCTDeepLinkAction.m; path = UARCTModule/UARCTDeepLinkAction.m; sourceTree = "<group>"; };
49-
F8A9D23A1F3CF8870087D225 /* UARCTMessageViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = UARCTMessageViewController.m; path = UARCTModule/UARCTMessageViewController.m; sourceTree = "<group>"; };
50-
F8A9D23C1F3CF8B90087D225 /* UARCTMessageViewController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = UARCTMessageViewController.h; path = UARCTModule/UARCTMessageViewController.h; sourceTree = "<group>"; };
5148
F8AA2B661EEF04C0008653D8 /* UARCTMessageCenter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UARCTMessageCenter.h; path = UARCTModule/UARCTMessageCenter.h; sourceTree = "<group>"; };
5249
F8AA2B671EEF04C0008653D8 /* UARCTMessageCenter.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = UARCTMessageCenter.m; path = UARCTModule/UARCTMessageCenter.m; sourceTree = "<group>"; };
5350
/* End PBXFileReference section */
@@ -82,8 +79,6 @@
8279
457511B823A41C7900E4B1AD /* UARCTModuleVersion.m */,
8380
6E42C7AD1EBA953100C85B3A /* UrbanAirshipReactModule.h */,
8481
6E42C7AE1EBA953100C85B3A /* UrbanAirshipReactModule.m */,
85-
F8A9D23A1F3CF8870087D225 /* UARCTMessageViewController.m */,
86-
F8A9D23C1F3CF8B90087D225 /* UARCTMessageViewController.h */,
8782
);
8883
name = UARCTModule;
8984
sourceTree = "<group>";
@@ -170,7 +165,6 @@
170165
isa = PBXSourcesBuildPhase;
171166
buildActionMask = 2147483647;
172167
files = (
173-
F8A9D23B1F3CF8870087D225 /* UARCTMessageViewController.m in Sources */,
174168
457511BA23A41C7A00E4B1AD /* UARCTModuleVersion.m in Sources */,
175169
6E42C7AF1EBA953100C85B3A /* UARCTAutopilot.m in Sources */,
176170
6ED67C292318812700169F5C /* UARCTMessageView.m in Sources */,

urbanairship-react-native/ios/UARCTModule/UARCTMessageCenter.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ - (void)displayMessageCenterForMessageID:(NSString *)messageID animated:(BOOL)an
5252
}
5353

5454
- (void)dismissMessageCenterAnimated:(BOOL)animated {
55-
// no-op
55+
if ([[NSUserDefaults standardUserDefaults] boolForKey:UARCTAutoLaunchMessageCenterKey]) {
56+
[[UAMessageCenter shared].defaultUI dismissMessageCenterAnimated:animated];
57+
}
5658
}
5759

5860
@end

urbanairship-react-native/ios/UARCTModule/UARCTMessageViewController.h

Lines changed: 0 additions & 12 deletions
This file was deleted.

urbanairship-react-native/ios/UARCTModule/UARCTMessageViewController.m

Lines changed: 0 additions & 42 deletions
This file was deleted.

urbanairship-react-native/ios/UARCTModule/UrbanAirshipReactModule.m

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#import "UARCTDeepLinkAction.h"
66
#import "UARCTAutopilot.h"
77
#import "UARCTMessageCenter.h"
8-
#import "UARCTMessageViewController.h"
98

109
#if __has_include("AirshipLib.h")
1110
#import "UAInAppMessageHTMLAdapter.h"
@@ -16,7 +15,6 @@
1615
#endif
1716

1817
@interface UrbanAirshipReactModule()
19-
@property (nonatomic, weak) UARCTMessageViewController *messageViewController;
2018
@end
2119

2220
@implementation UrbanAirshipReactModule
@@ -491,24 +489,18 @@ + (BOOL)requiresMainQueueSetup {
491489
messageId:(NSString *)messageId
492490
displayMessage_resolver:(RCTPromiseResolveBlock)resolve
493491
rejecter:(RCTPromiseRejectBlock)reject) {
494-
UARCTMessageViewController *mvc = [[UARCTMessageViewController alloc] initWithNibName:@"UADefaultMessageCenterMessageViewController" bundle:[UAMessageCenterResources bundle]];
495-
[mvc loadMessageForID:messageId];
496492

497-
UINavigationController *navController = [[UINavigationController alloc] initWithRootViewController:mvc];
498-
self.messageViewController = mvc;
499-
500-
dispatch_async(dispatch_get_main_queue(), ^{
501-
[[UIApplication sharedApplication].keyWindow.rootViewController presentViewController:navController animated:YES completion:nil];
502-
});
493+
dispatch_async(dispatch_get_main_queue(), ^{
494+
[[UAMessageCenter shared] displayMessageForID:messageId];
495+
});
503496
}
504497

505498
RCT_REMAP_METHOD(dismissMessage,
506499
dismissMessage_resolver:(RCTPromiseResolveBlock)resolve
507500
rejecter:(RCTPromiseRejectBlock)reject) {
508501

509502
dispatch_async(dispatch_get_main_queue(), ^{
510-
[self.messageViewController dismissViewControllerAnimated:YES completion:nil];
511-
self.messageViewController = nil;
503+
[[UAMessageCenter shared] dismiss:YES];
512504
});
513505
}
514506

0 commit comments

Comments
 (0)