Skip to content

Commit c307931

Browse files
authored
Merge pull request #7 from urbanairship/MB-2216
[MB-2216] React Native Sample, bindings improvements
2 parents 7716816 + 3b7d3f5 commit c307931

File tree

3 files changed

+413
-55
lines changed

3 files changed

+413
-55
lines changed

ios/UARCTModule/UrbanAirshipReactModule.m

+19-18
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,29 @@ - (RCTBridge *)bridge {
5555
}
5656

5757
RCT_EXPORT_METHOD(setNamedUser:(NSString *)namedUser) {
58-
namedUser = [namedUser stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
59-
[UAirship namedUser].identifier = namedUser;
58+
namedUser = [namedUser stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
59+
[UAirship namedUser].identifier = namedUser.length ? namedUser : nil;
6060
}
6161

62+
RCT_REMAP_METHOD(getNamedUser,
63+
getNamedUser_resolver:(RCTPromiseResolveBlock)resolve
64+
rejecter:(RCTPromiseRejectBlock)reject) {
65+
resolve([UAirship namedUser].identifier);
66+
}
67+
68+
6269
RCT_EXPORT_METHOD(addTag:(NSString *)tag) {
63-
[[UAirship push] addTag:tag];
64-
[[UAirship push] updateRegistration];
70+
if (tag) {
71+
[[UAirship push] addTag:tag];
72+
[[UAirship push] updateRegistration];
73+
}
6574
}
6675

6776
RCT_EXPORT_METHOD(removeTag:(NSString *)tag) {
68-
[[UAirship push] removeTag:tag];
69-
[[UAirship push] updateRegistration];
77+
if (tag) {
78+
[[UAirship push] removeTag:tag];
79+
[[UAirship push] updateRegistration];
80+
}
7081
}
7182

7283
RCT_REMAP_METHOD(getTags,
@@ -75,16 +86,6 @@ - (RCTBridge *)bridge {
7586
resolve([UAirship push].tags ?: [NSArray array]);
7687
}
7788

78-
RCT_EXPORT_METHOD(addTag:(NSArray *)tags group:(NSString *)group) {
79-
[[UAirship push] addTags:tags group:group];
80-
[[UAirship push] updateRegistration];
81-
}
82-
83-
RCT_EXPORT_METHOD(removeTag:(NSArray *)tags group:(NSString *)group) {
84-
[[UAirship push] removeTags:tags group:group];
85-
[[UAirship push] updateRegistration];
86-
}
87-
8889
RCT_EXPORT_METHOD(setAnalyticsEnabled:(BOOL)enabled) {
8990
[UAirship shared].analytics.enabled = enabled;
9091
}
@@ -191,7 +192,7 @@ - (RCTBridge *)bridge {
191192
}];
192193
}
193194

194-
RCT_EXPORT_METHOD(editNamedUserGroups:(NSArray *)operations) {
195+
RCT_EXPORT_METHOD(editNamedUserTagGroups:(NSArray *)operations) {
195196
UANamedUser *namedUser = [UAirship namedUser];
196197
for (NSDictionary *operation in [operations objectAtIndex:0]) {
197198
NSString *group = operation[@"group"];
@@ -205,7 +206,7 @@ - (RCTBridge *)bridge {
205206
[namedUser updateTags];
206207
}
207208

208-
RCT_EXPORT_METHOD(editChannelGroups:(NSArray *)operations) {
209+
RCT_EXPORT_METHOD(editChannelTagGroups:(NSArray *)operations) {
209210
for (NSDictionary *operation in [operations objectAtIndex:0]) {
210211
NSString *group = operation[@"group"];
211212
if ([operation[@"operationType"] isEqualToString:@"add"]) {

0 commit comments

Comments
 (0)