Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve a11y by using button instead of links #1752

Open
mrleblanc101 opened this issue Aug 17, 2022 · 1 comment · May be fixed by #1753
Open

Improve a11y by using button instead of links #1752

mrleblanc101 opened this issue Aug 17, 2022 · 1 comment · May be fixed by #1753
Labels
bug

Comments

@mrleblanc101
Copy link

Description

Links should only be used when the URL change.
<a role="button"> is not the same as <button type="button">.

Expected Behavior

If you are creating a button, use a <button>.

Actual Behavior

The library generate links with no href and role="button"
@mrleblanc101 mrleblanc101 linked a pull request Aug 17, 2022 that will close this issue
Open
@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 16, 2022
@afshinm afshinm added bug and removed wontfix labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A11y improvements mrleblanc101/intro.js
2 participants
@afshinm @mrleblanc101