Stabilise?

[Ravenslofty]

@dholroyd Since this is a low-level but mostly static binding, should we just stabilise this? I don't see the API surface changing any time soon.

[dholroyd]

I think you are very likely correct.

Someone mentioned to me the idea of vendoring a snaphot of usbdevice_fs.h into the repo, so that build.rs is not dependant on the filesystem layout of the build machine. I mention this in the context of stabilisation because I think it makes the build more reproducible.

If you want to stabilise without that change, I think that's still fine!

[Ravenslofty]

Well, we could bundle in the generated bindings.rs instead? That's going to speed up builds, too, because then the build.rs script doesn't have to run, and we don't need to depend on bindgen in this crate.

[newAM]

Well, we could bundle in the generated bindings.rs instead? That's going to speed up builds, too, because then the build.rs script doesn't have to run, and we don't need to depend on bindgen in this crate.

I created a PR to make bindgen optional: #3

[newAM]

Would it be possible to get a release with the new changes?

I would like to update the dependencies in usbfs-device, but I need a release of this to update nix in the parent crate 👍

[Ravenslofty]

I'm pretty sure that's down to @dholroyd, since the usbfs-sys crate belongs to him.

[dholroyd]

Sorry for not replying earlier! Perfectly happy to stabilize and release (I think @Ravenslofty is the one currently able to publish this to crates.io)

And in general I am happy for you to take decisions on these USB crates without requiring my up-front consent -- haven't been working in this area in aaaaages!